Bug 218770 - devel/arduino18 - build fails for 1.8.2
Summary: devel/arduino18 - build fails for 1.8.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Boris Samorodov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-20 06:42 UTC by Zane C. Bowers-Hadley
Modified: 2017-04-21 02:06 UTC (History)
2 users (show)

See Also:
bsam: maintainer-feedback+


Attachments
ouput from make (4.72 KB, text/plain)
2017-04-20 06:42 UTC, Zane C. Bowers-Hadley
no flags Details
svn(1) diff of devel/arduino18 (372 bytes, patch)
2017-04-20 14:10 UTC, Kyle Evans
kevans: maintainer-approval+
Details | Diff
svn(1) diff of devel/arduino-core (686 bytes, patch)
2017-04-20 18:42 UTC, Kyle Evans
kevans: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zane C. Bowers-Hadley 2017-04-20 06:42:25 UTC
Created attachment 181930 [details]
ouput from make

It fails with this....

compile:
    [mkdir] Created dir: /usr/obj/ARC/src/FreeBSD/ports/head/devel/arduino18/work/Arduino-1.8.2/arduino-core/bin
    [javac] Compiling 134 source files to /usr/obj/ARC/src/FreeBSD/ports/head/devel/arduino18/work/Arduino-1.8.2/arduino-core/bin
    [javac] javac: invalid target release: 1.8
    [javac] Usage: javac <options> <source files>
    [javac] use -help for a list of possible options

BUILD FAILED
/usr/obj/ARC/src/FreeBSD/ports/head/devel/arduino18/work/Arduino-1.8.2/build/build.xml:103: The following error occurred while executing this line:
/usr/obj/ARC/src/FreeBSD/ports/head/devel/arduino18/work/Arduino-1.8.2/build/build.xml:150: The following error occurred while executing this line:
/usr/obj/ARC/src/FreeBSD/ports/head/devel/arduino18/work/Arduino-1.8.2/arduino-core/build.xml:41: Compile failed; see the compiler error output for details.



For the full make output, see the attached file.
Comment 1 Kyle Evans freebsd_committer 2017-04-20 14:10:51 UTC
Created attachment 181937 [details]
svn(1) diff of devel/arduino18

Hi,

Please try the attached patch. It will likely force you to pull in java/openjdk8 because I was not previously specifying required Java version =(.

Thanks,

Kyle Evans
Comment 2 Zane C. Bowers-Hadley 2017-04-20 18:18:10 UTC
It builds and installs now, but is not usable.

[kitsune@vixen42]/home/kitsune% arduino 
Picked up JAVA_TOOL_OPTIONS: 
java.lang.NullPointerException
        at processing.app.BaseNoGui.createToolPreferences(BaseNoGui.java:703)
        at processing.app.BaseNoGui.initPackages(BaseNoGui.java:501)
        at processing.app.Base.<init>(Base.java:257)
        at processing.app.Base.main(Base.java:140)
Exit 255
Comment 3 Kyle Evans freebsd_committer 2017-04-20 18:42:05 UTC
Created attachment 181957 [details]
svn(1) diff of devel/arduino-core

Hi,

Apologies for the breakage -- the attached patch to devel/arduino-core and a rebuild of that should fix it. If you want to try it without rebuilding, this is the end result of that patch to /usr/local/arduino/hardware/package_index_bundled.json:

--- package_index_bundled.json.orig     2017-04-20 13:40:17.586096000 -0500
+++ package_index_bundled.json  2017-04-20 13:40:28.961958000 -0500
@@ -85,36 +85,36 @@
           "name": "avrdude",
           "version": "6.3.0-arduino9",
           "systems": [
             {
-                               "host": "-freebsd12"
+                               "host": "amd64-freebsd12"
                        }
           ]
         },
         {
           "name": "avr-gcc",
           "version": "4.9.2-atmel3.5.4-arduino2",
           "systems": [
             {
-                               "host": "-freebsd12"
+                               "host": "amd64-freebsd12"
             }
           ]
         },
         {
           "name": "bossac",
           "version": "1.7.0",
           "systems": [
             {
-                               "host": "-freebsd12"
+                               "host": "amd64-freebsd12"
             }
           ]
         },
         {
           "name": "arduinoOTA",
           "version": "1.1.1",
           "systems": [
             {
-                               "host": "-freebsd12"
+                               "host": "amd64-freebsd12"
             }
           ]
         }
       ]
Comment 4 Kyle Evans freebsd_committer 2017-04-20 18:48:29 UTC
Hi bsam@,

Can you please pick up these two patches, one to devel/arduino18 and the other to devel/arduino-core?

arduino18 shouldn't need a PORTREVISION bump because this just fixes breakage for those that didn't previously have java/openjdk8 installed.

arduino-core gets a PORTREVISION bump since it's entirely possibly people (such as Zane here) have already installed the broken-ness.

I really wish upstream would make this a little bit easier, forego the platform checks and just let us specify a path to a working version, but my previous discussion with them on it didn't seem to go anywhere. =(
Comment 5 Boris Samorodov freebsd_committer 2017-04-20 19:00:08 UTC
Take.
Comment 6 Boris Samorodov freebsd_committer 2017-04-20 19:16:36 UTC
> arduino18 shouldn't need a PORTREVISION bump because this just fixes breakage for those that didn't previously have java/openjdk8 installed.

Hm, package dependencies would change. I'll bump PORTREVISION there too.
Comment 7 Kyle Evans freebsd_committer 2017-04-20 19:18:05 UTC
(In reply to Boris Samorodov from comment #6)

I suppose that's true- fair enough. =)

Thanks!
Comment 8 commit-hook freebsd_committer 2017-04-20 19:57:05 UTC
A commit references this bug:

Author: bsam
Date: Thu Apr 20 19:55:58 UTC 2017
New revision: 438992
URL: https://svnweb.freebsd.org/changeset/ports/438992

Log:
  devel/arduino-core: fix ARCH name reintplacement.

  PR:		218770
  Submitted by:	Zane C. Bowers-Hadley <vvelox@vvelox.net>
  Patched by:	Kyle Evans <bsdports@kyle-evans.net> (maintainer)

Changes:
  head/devel/arduino-core/Makefile
Comment 9 commit-hook freebsd_committer 2017-04-20 19:59:09 UTC
A commit references this bug:

Author: bsam
Date: Thu Apr 20 19:58:08 UTC 2017
New revision: 438993
URL: https://svnweb.freebsd.org/changeset/ports/438993

Log:
  devel/arduino18: Java 1.8+ is needed.

  PR:		218770
  Submitted by:	Zane C. Bowers-Hadley <vvelox@vvelox.net>
  Reported by:	Kyle Evans <bsdports@kyle-evans.net> (maintainer))

Changes:
  head/devel/arduino18/Makefile
Comment 10 Boris Samorodov freebsd_committer 2017-04-20 19:59:56 UTC
Committed, thanks!
Comment 11 Zane C. Bowers-Hadley 2017-04-21 02:06:24 UTC
Tested and it all works now. Thanks ya'll!