Created attachment 182045 [details] patch to update khal and vdirsyncer to newest version Hello, attached is a patch to update khal to release 0.9.5 and vdirsyncer to 0.15.0. Both ports are python 3 only so all dependencies are ported to python 3 too. Poudriere finished building the packages without any errors and using the packages in poudriere jail worked too. Best
Could you attach the poudriere log, please?
Read through the patches. No. Sorry, that isn't acceptable from my point of view. The point is you just break py27-* packages. Please add the updates as py3[35]-* packages, that is, I guess, separate ones, at least for khal and vdirsyncer. I guess, there's no need to transfer the dependencies to py3. Also, I don't think a single patch is ok: please break down the patch into separate patches for each port.
Hello che, thanks for your feedback. I attached the poudriere log files for khal and vdirsyncer. What do you mean with that I have broken py27-* packages? Indeed khal and vdirsyncer are not buildable with py27 anymore but upstream dropped support for python<3. For all dependencies I added extra py3-packages. I know it's not good practice to have one patch for both ports but they share a lot of dependencies. So merging the second patch without the first patch would lead to build errors. If this is not a problem I will provide two different patches. After clarifying these two points I will attach an improved patch.
Created attachment 182136 [details] Poudriere log for khal 0.9.5
Created attachment 182137 [details] poudriere log for vdirsyncer 0.15.0
My point is that py27-khal should remain with its old version while it would be great to add py35-khal with a newer one. Yes, I know the upstream have dumped 2.7 support, but they still somewhat backport patches to the older py27 versions. Regarding multiple patches, please add those patches separately: single package -> single bug -> single patch. Sorry, this is how FreeBSD ports are updated. I don't think the cumulative patch you have kindly provided can be merged "as is".
Another standard question: what does `portlint -AC` say in these ports' directories?
Okay, now I got it ;-) Sorry, I'm still new to the whole process. I will open a bug report for every single port at the weekend.
The update of deskutils/py-vdirsyncer is handled in bug #217981.
khal 0.9.8 has been released in the meantime.
*** Bug 223341 has been marked as a duplicate of this bug. ***
Could someone please mark this as DUPLICATE of 221736 (Khal)? PS. py-vdirsyncer was updated already. Thanks!
*** This bug has been marked as a duplicate of bug 221736 ***