Bug 218850 - deskutils/py-khal: deskutils/py-vdirsyncer: update to 0.9.5 (patch provided)
Summary: deskutils/py-khal: deskutils/py-vdirsyncer: update to 0.9.5 (patch provided)
Status: Closed DUPLICATE of bug 221736
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords:
: 223341 (view as bug list)
Depends on: 218935 218991 219234
Blocks:
  Show dependency treegraph
 
Reported: 2017-04-24 15:26 UTC by rsos+freebsd
Modified: 2017-12-10 10:10 UTC (History)
3 users (show)

See Also:
che: maintainer-feedback-


Attachments
patch to update khal and vdirsyncer to newest version (25.63 KB, patch)
2017-04-24 15:26 UTC, rsos+freebsd
no flags Details | Diff
Poudriere log for khal 0.9.5 (30.23 KB, text/x-log)
2017-04-27 21:00 UTC, rsos+freebsd
no flags Details
poudriere log for vdirsyncer 0.15.0 (29.45 KB, text/x-log)
2017-04-27 21:01 UTC, rsos+freebsd
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description rsos+freebsd 2017-04-24 15:26:26 UTC
Created attachment 182045 [details]
patch to update khal and vdirsyncer to newest version

Hello,

attached is a patch to update khal to release 0.9.5 and vdirsyncer to 0.15.0. Both ports are python 3 only so all dependencies are ported to python 3 too.

Poudriere finished building the packages without any errors and using the packages in poudriere jail worked too.

Best
Comment 1 Maxim Filimonov 2017-04-27 19:57:39 UTC
Could you attach the poudriere log, please?
Comment 2 Maxim Filimonov 2017-04-27 20:02:44 UTC
Read through the patches. No. Sorry, that isn't acceptable from my point of view. The point is you just break py27-* packages. Please add the updates as py3[35]-* packages, that is, I guess, separate ones, at least for khal and vdirsyncer. I guess, there's no need to transfer the dependencies to py3. Also, I don't think a single patch is ok: please break down the patch into separate patches for each port.
Comment 3 rsos+freebsd 2017-04-27 20:58:48 UTC
Hello che,
thanks for your feedback. I attached the poudriere log files for khal and vdirsyncer.

What do you mean with that I have broken py27-* packages? Indeed khal and vdirsyncer are not buildable with py27 anymore but upstream dropped support for python<3. For all dependencies I added extra py3-packages.

I know it's not good practice to have one patch for both ports but they share a lot of dependencies. So merging the second patch without the first patch would lead to build errors. If this is not a problem I will provide two different patches.

After clarifying these two points I will attach an improved patch.
Comment 4 rsos+freebsd 2017-04-27 21:00:38 UTC
Created attachment 182136 [details]
Poudriere log for khal 0.9.5
Comment 5 rsos+freebsd 2017-04-27 21:01:02 UTC
Created attachment 182137 [details]
poudriere log for vdirsyncer 0.15.0
Comment 6 Maxim Filimonov 2017-04-27 21:04:39 UTC
My point is that py27-khal should remain with its old version while it would be great to add py35-khal with a newer one. Yes, I know the upstream have dumped 2.7 support, but they still somewhat backport patches to the older py27 versions.

Regarding multiple patches, please add those patches separately: single package -> single bug -> single patch. Sorry, this is how FreeBSD ports are updated. I don't think the cumulative patch you have kindly provided can be merged "as is".
Comment 7 Maxim Filimonov 2017-04-27 21:07:29 UTC
Another standard question: what does `portlint -AC` say in these ports' directories?
Comment 8 rsos+freebsd 2017-04-28 08:11:41 UTC
Okay, now I got it ;-) Sorry, I'm still new to the whole process. I will open a bug report for every single port at the weekend.
Comment 9 Sebastian Schwarz 2017-10-31 14:05:43 UTC
The update of deskutils/py-vdirsyncer is handled in bug #217981.
Comment 10 Sebastian Schwarz 2017-10-31 14:11:50 UTC
khal 0.9.8 has been released in the meantime.
Comment 11 Sebastian Schwarz 2017-10-31 14:16:37 UTC
*** Bug 223341 has been marked as a duplicate of this bug. ***
Comment 12 Alexandre C. Guimarães freebsd_committer freebsd_triage 2017-12-08 15:40:52 UTC
Could someone please mark this as DUPLICATE of 221736 (Khal)?

PS. py-vdirsyncer was updated already.

Thanks!
Comment 13 rsos+freebsd 2017-12-10 10:10:43 UTC

*** This bug has been marked as a duplicate of bug 221736 ***