Bug 218928 - math/scilab partial patch to fix build with OPTIONS_UNSET=DOCS
Summary: math/scilab partial patch to fix build with OPTIONS_UNSET=DOCS
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Only Me
Assignee: Max Brazhnikov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-04-28 07:55 UTC by Beeblebrox
Modified: 2018-05-11 12:12 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (makc)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Beeblebrox 2017-04-28 07:55:24 UTC
Hello.
My poudriere.d/make.conf file has globally defined "OPTIONS_UNSET= DOCS EXAMPLES NLS", This setting breaks the build for math/scilab when the GUI flag is turned on, because the Makefile sets by default java/javahelp and textproc/docbook-xsl when GUI is enabled. Example from poudriere log:

-- Building documentation (en_US) --
LANG=C LC_ALL=en_US.UTF-8 SCI_DISABLE_TK=1 SCI_JAVA_ENABLE_HEADLESS=1 ./bin/scilab-adv-cli -noatomsautoload -nb -l en_US -nouserstartup -e "try xmltojar([],[],'en_US');catch disp(lasterror()); exit(-1);end;exit(0);"
Building the Scilab manual master document for en_US.
Building the scilab manual file [javaHelp]
!A fatal error has been detected by Scilab.
!Your instance will probably quit unexpectedly soon. 

Objective: separate this out to where it belongs, under DOCS. The patch is incomplete because:
a) Although poudriere build completes without error, fails at packaging stage due to pkg-plist entries regarding help files (not fixed by this patch).
b) Most likely has other omissions as I'm not that familiar with the port.

math/scilab/Makefile:

@@  - 45,48  +45,48  @@
--OPTIONS_DEFINE= GUI OCAML TK
++OPTIONS_DEFINE= GUI OCAML TK DOCS
OPTIONS_RADIO=  BLAS
OPTIONS_RADIO_BLAS=     ATLAS NETLIB OPENBLAS
--OPTIONS_DEFAULT= GUI NETLIB OCAML TK
++OPTIONS_DEFAULT= GUI NETLIB OCAML TK DOCS

@@  - 62  @@
 --${JAVALIBDIR}/jhall.jar:java/javahelp \

@@  - 81,84  +81,84  @@
-- _GUI_DEPENDS+=  ${LOCALBASE}/share/xsl/docbook/javahelp/javahelp.xsl:textpro
    c/docbook-xsl \
++ _GUI_DEPENDS+=  ${JAVALIBDIR}/saxon9he.jar:textproc/saxon-he \
--              ${JAVALIBDIR}/saxon9he.jar:textproc/saxon-he \
++            ${JAVALIBDIR}/xml-apis-ext.jar:textproc/xml-commons \
--               ${JAVALIBDIR}/xml-apis-ext.jar:textproc/xml-commons \
++             xsltproc:textproc/libxslt
--               xsltproc:textproc/libxslt
++ _DOCS_DEPENDS+=  xsltproc:textproc/libxslt

@@  - 94  +94  @@
--GUI_ALL_TARGET= all doc
++GUI_ALL_TARGET= all

@@  - 97,99  +97,100  @@
--GUI_CONFIGURE_ON= --with-jdk=${JAVA_HOME} \
++GUI_CONFIGURE_ON= --with-jdk=${JAVA_HOME}
--          --with-docbook=${LOCALBASE}/share/xsl/docbook \
++DOCS_CONFIGURE_OFF=     --disable-build-help
--          --enable-build-help
++DOCS_CONFIGURE_ON=      --with-docbook=${LOCALBASE}/share/xsl/docbook \
++         --enable-build-help

@@  +104  @@
++DOCS_IMPLIES=          GUI
Comment 1 w.schwarzenfeld freebsd_triage 2018-01-16 12:58:01 UTC
Maintainer feedback?
Comment 2 w.schwarzenfeld freebsd_triage 2018-05-11 12:12:44 UTC
Maintainer timeout?