Bug 219150 - [NEW PORT] security/klee: Symbolic virtual machine built on top of the LLVM compiler infrastructure
Summary: [NEW PORT] security/klee: Symbolic virtual machine built on top of the LLVM c...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yuri Victorovich
URL:
Keywords: feature, needs-qa
Depends on: 221321
Blocks:
  Show dependency treegraph
 
Reported: 2017-05-08 18:23 UTC by larca
Modified: 2018-07-23 05:29 UTC (History)
6 users (show)

See Also:


Attachments
Shar (3.05 KB, text/plain)
2017-05-08 18:23 UTC, larca
no flags Details
new shar (3.14 KB, text/plain)
2017-05-14 19:06 UTC, larca
no flags Details
updated shar (3.10 KB, application/x-shar)
2017-08-02 15:49 UTC, Gleb Popov
no flags Details
updated shar (3.11 KB, text/plain)
2017-09-05 14:28 UTC, Gleb Popov
no flags Details
updated shar (3.10 KB, text/plain)
2017-09-11 15:25 UTC, Gleb Popov
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description larca 2017-05-08 18:23:23 UTC
Created attachment 182416 [details]
Shar
Comment 1 Martin Wilke freebsd_committer freebsd_triage 2017-05-13 05:02:18 UTC
Hi,

Is there any chance to not depend on clang34? We're planing to remove clang34 soonish, it would be not good to have a new port relying on it.

Thanks,
- Martin
Comment 2 larca 2017-05-14 19:06:48 UTC
Created attachment 182599 [details]
new shar

(In reply to Martin Wilke from comment #1)
I have updated the port with work-in-progress patches to support llvm39.
I think it won't hurt, because the current version of KLEE isn't a stable release either.
Comment 3 Gleb Popov freebsd_committer freebsd_triage 2017-06-04 12:01:52 UTC
Ping.
Comment 4 larca 2017-07-29 09:58:33 UTC
Ping?
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2017-08-01 05:53:21 UTC
Could you please confirm this port passes QA (portlint & poudriere in particular). 

For more information and testing instruction see: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/testing.html
Comment 6 Gleb Popov freebsd_committer freebsd_triage 2017-08-02 15:49:05 UTC
Created attachment 184961 [details]
updated shar

I've fixed all qa warnings except this one:

Error: /usr/local/bin/gen-random-bout is linked to /usr/local/lib/libz3.so which does not have a SONAME.  math/z3 needs to be fixed.
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2017-08-06 03:57:23 UTC
(In reply to arrowd from comment #6)

Thaznk you for the updated attachment. Could you please create a new (separate issue) for math/z3 port please, adding this issue to its "Blocks" field if the fix needs to be committed before this issue can be committed and resolved
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2017-08-06 03:57:54 UTC
Comment on attachment 184961 [details]
updated shar

This attachment needs maintainer (original reporter) approval
Comment 9 larca 2017-08-08 12:25:17 UTC
I approve.
Comment 10 Gleb Popov freebsd_committer freebsd_triage 2017-09-05 14:28:28 UTC
Created attachment 186079 [details]
updated shar

The blocker issue has been fixed. Can this finally get in? We also agreed with larca that I'll be maintaining this.
Comment 11 Richard Gallamore freebsd_committer freebsd_triage 2017-09-10 22:37:21 UTC
A few items that should be corrected on this port.

* Cant figure out the port version reason. That seems to be for the 1.3.x branch but according to git describe --tags 6be29d0, the version is v1.0.0-452-g6be29d0.
So this should be DISTVERSIONPREFIX= v DISTVERSION= 1.0.0-452 DISTVERSIONSUFFIX= -g6be29d0 and remove tagname.
* The portname should not be in the comment. (KLEE)
* In libdepends, libtcmalloc.so.4. The .4 should be removed otherwise this port will break when this lib version is bumped.
Comment 12 Gleb Popov freebsd_committer freebsd_triage 2017-09-11 15:25:09 UTC
Created attachment 186262 [details]
updated shar

The latest KLEE release is 1.4.0 and this port is just a few commits behind it. I'd update it to 1.4.0, but I lack time right now, and this port is stalled for much too long. So I insist on keeping this as is for now.

I've addressed other two comments in new shar.
Comment 13 Gleb Popov freebsd_committer freebsd_triage 2017-09-24 14:36:27 UTC
Ping.
Comment 14 Gleb Popov freebsd_committer freebsd_triage 2017-10-13 09:09:34 UTC
Ping again. It is stalled for almost half a year.
Comment 15 Yuri Victorovich freebsd_committer freebsd_triage 2018-07-21 23:58:12 UTC
klee breaks with llvm 60, 50, 40, 38: https://github.com/klee/klee/issues/939
Unclear what llvm version doesn't it need.
Comment 16 Yuri Victorovich freebsd_committer freebsd_triage 2018-07-21 23:58:35 UTC
(In reply to Yuri Victorovich from comment #15)

* Unclear what llvm version does it need.
Comment 17 Gleb Popov freebsd_committer freebsd_triage 2018-07-22 21:43:01 UTC
GitHub repo has pull request that adds LLVM 6.0 support. I was waiting for it to land to go on with this port.
Comment 18 Yuri Victorovich freebsd_committer freebsd_triage 2018-07-22 21:51:12 UTC
They said that the latest they support now is llvm38.
I'm already running poudriere with it.
Comment 19 Yuri Victorovich freebsd_committer freebsd_triage 2018-07-23 03:19:32 UTC
Committed with changes.
Thank you for your submission!
Comment 20 commit-hook freebsd_committer freebsd_triage 2018-07-23 03:20:13 UTC
A commit references this bug:

Author: yuri
Date: Mon Jul 23 03:19:27 UTC 2018
New revision: 475144
URL: https://svnweb.freebsd.org/changeset/ports/475144

Log:
  New port: security/klee: Symbolic virtual machine built on top of the LLVM

  PR:		219150
  Submitted by:	larca <itbot@list.ru>

Changes:
  head/security/Makefile
  head/security/klee/
  head/security/klee/Makefile
  head/security/klee/distinfo
  head/security/klee/files/
  head/security/klee/files/patch-CMakeLists.txt
  head/security/klee/files/patch-cmake_find__stp.cmake
  head/security/klee/files/patch-lib_Core_Executor.cpp
  head/security/klee/pkg-descr
  head/security/klee/pkg-plist
Comment 21 Gleb Popov freebsd_committer freebsd_triage 2018-07-23 05:11:18 UTC
Original maintainer gave up on this. Set me as maintainer.
Comment 22 Yuri Victorovich freebsd_committer freebsd_triage 2018-07-23 05:21:46 UTC
(In reply to Gleb Popov from comment #21)

Ok, will do this.
Comment 23 commit-hook freebsd_committer freebsd_triage 2018-07-23 05:29:56 UTC
A commit references this bug:

Author: yuri
Date: Mon Jul 23 05:28:54 UTC 2018
New revision: 475146
URL: https://svnweb.freebsd.org/changeset/ports/475146

Log:
  security/klee: arrowd@FreeBSD.org takes maintainership

  The original submitter gave up on the klee port.

  Also update COMMENT and move -DFREEBSD_STP_STATIC_LIBRARY to the STP option section.

  PR:		219150
  Requested by:	arrowd (maintainership change)

Changes:
  head/security/klee/Makefile