Bug 219174 - [NEW PORT] archivers/py-bup: Very efficient backup system based on the git packfile format
Summary: [NEW PORT] archivers/py-bup: Very efficient backup system based on the git pa...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Rodrigo Osorio
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-09 22:47 UTC by Jose G. Juanino
Modified: 2018-05-24 22:39 UTC (History)
2 users (show)

See Also:


Attachments
bup shar file (8.72 KB, text/plain)
2017-05-09 22:47 UTC, Jose G. Juanino
no flags Details
New version of shar file (9.32 KB, text/plain)
2017-05-14 16:39 UTC, Jose G. Juanino
no flags Details
py-bup port with fixes (8.87 KB, text/plain)
2018-04-24 14:32 UTC, Rodrigo Osorio
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jose G. Juanino 2017-05-09 22:47:10 UTC
Created attachment 182453 [details]
bup shar file

Dear FreeBSD committer,

I submit a port for making backups (as attic, zbackup or borbackup). 
See https://github.com/bup/bup

Thanks.
Comment 1 Jose G. Juanino 2017-05-14 16:39:45 UTC
Created attachment 182596 [details]
New version of shar file

Dear Martin,

Since the first version of the shar, I have noticed some issues:

1. bup does not support python3. Thus, we need to stick to USES=python:2 instead of python:2.6+.

2. As consequence of (1), it is not possible to make use of "fuse" option, as it only works with python:3+. Thus, it has been removed from OPTIONS_DEFINE.

3. I have added support for test suite, with a proper patch (files/patch-t_test-sparse-files that warns about zfs and sparse files).

Sorry for the annoyances. Regards.
Comment 2 Martin Wilke freebsd_committer freebsd_triage 2017-05-15 04:41:55 UTC
Hi,

thanks for the update. I'll look in to it later today.
Comment 3 Mathieu Arnold freebsd_committer freebsd_triage 2017-07-06 13:52:46 UTC
Assignee timeout. Give back to the pool.
Comment 4 Rodrigo Osorio freebsd_committer freebsd_triage 2018-04-24 14:32:15 UTC
Created attachment 192779 [details]
py-bup port with fixes

changes suggested into you port Makefile
Comment 5 Rodrigo Osorio freebsd_committer freebsd_triage 2018-04-24 14:36:34 UTC
Hi,

I did some fixes in your port, including making portlint happy.
I also suggest to make the DOCS option available by default, it doesn't change that much the port size and is not too much work for builder.


The IGNORE section suggests you define the port to be built and install manually or with portupgrade, can you confirm that ? Otherwise this section hasn't too much sense.
Comment 6 Jose G. Juanino 2018-05-02 17:26:54 UTC
Hi, sorry for the late replay.

I agree with your comments.

Please remove the IGNORE section, with port flavors does not apply (I believe).

Only a final minor tweak: the proper content of files/patch-t_test-sparse-files is:

--- t/test-sparse-files.sh.orig 2017-05-14 11:27:06 UTC
+++ t/test-sparse-files.sh
@@ -31,6 +31,13 @@ if [ "$probe_size" -ge "$((data_size / 1
     exit 0
 fi

+if [ "$(current-filesystem)" == "zfs" ]; then
+    WVSTART "WARNING!! If zfs compression is enabled in the current " \
+       "filesytem, sparse test might fail!!. " \
+    " See https://groups.google.com/forum/#!topic/bup-list/NZCJ5wHwbFE"
+fi
+
+
 WVSTART "sparse restore on $(current-filesystem), assuming ${block_size}B blocks"

 WVPASS bup init


Regards
Comment 7 commit-hook freebsd_committer freebsd_triage 2018-05-24 22:38:37 UTC
A commit references this bug:

Author: rodrigo
Date: Thu May 24 22:37:36 UTC 2018
New revision: 470813
URL: https://svnweb.freebsd.org/changeset/ports/470813

Log:
  Add new port archivers/py-bup.

  A very efficient backup system based on the git packfile format.

  PR:		219174
  Submitted by:	jjuanino@gmail.com

Changes:
  head/archivers/Makefile
  head/archivers/py-bup/
  head/archivers/py-bup/Makefile
  head/archivers/py-bup/distinfo
  head/archivers/py-bup/files/
  head/archivers/py-bup/files/patch-Makefile
  head/archivers/py-bup/files/patch-t_test-sparse-files
  head/archivers/py-bup/pkg-descr
  head/archivers/py-bup/pkg-plist
Comment 8 Rodrigo Osorio freebsd_committer freebsd_triage 2018-05-24 22:39:38 UTC
Committed, thanks and sorry for the delay.