Bug 219199 - security/clamav: Unit tests fail after changes elsewhere in tree
Summary: security/clamav: Unit tests fail after changes elsewhere in tree
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Larry Rosenman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-10 19:44 UTC by Terry Kennedy
Modified: 2018-03-03 02:45 UTC (History)
5 users (show)

See Also:
bugzilla: maintainer-feedback? (garga)


Attachments
Port options file (654 bytes, text/plain)
2017-05-10 19:44 UTC, Terry Kennedy
no flags Details
Transcript of build failure (336.00 KB, text/plain)
2017-05-10 19:45 UTC, Terry Kennedy
no flags Details
Test Suite failure log (1.41 KB, text/plain)
2017-05-10 19:45 UTC, Terry Kennedy
no flags Details
svn-diff-clamav-test (3.33 KB, patch)
2018-01-23 16:52 UTC, Walter Schwarzenfeld
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Terry Kennedy 2017-05-10 19:44:27 UTC
Sometime between security/clamav 0.99.2_2 (r420045) and 0.99.2_3 (r437439) the ability to build the port (at least with the options I'm using) broke. The symptom is that a few of the unit tests fail.

Unfortunately, a number of changes were made to clamd's Makefile and files/* without bumping PORTREVISION, so it isn't possible for me to narrow down the timeframe other than "within the last 9 months".

The system is FreeBSD 10.3-STABLE r316646 amd64.

I am attaching my options file (in case it is option-related), a typescript of the portupgrade failure, and the test-suite.log. Hopefully someone who knows clamd will be able to easily identify the cause of this. Otherwise, I'll have to dig into things more deeply, as unfortunately I'm not sure the info in this PR is sufficient to track the problem down.
Comment 1 Terry Kennedy 2017-05-10 19:44:58 UTC
Created attachment 182482 [details]
Port options file
Comment 2 Terry Kennedy 2017-05-10 19:45:23 UTC
Created attachment 182483 [details]
Transcript of build failure
Comment 3 Terry Kennedy 2017-05-10 19:45:51 UTC
Created attachment 182484 [details]
Test Suite failure log
Comment 4 Terry Kennedy 2017-06-25 00:47:27 UTC
(In reply to Terry Kennedy from comment #0)

I get the same error on 11-STABLE. The failure is exactly the same. All that is needed to reproduce it is to enable the TESTS option - all other options can be left at default values.
Comment 5 Renato Botelho freebsd_committer freebsd_triage 2017-06-27 13:53:43 UTC
Terry,

Unfortunately I'm not able to reproduce it on poudriere using a 11.0-RELEASE amd64 jail. All tests succeeded here:

============================================================================
Testsuite summary for ClamAV 0.99.2
============================================================================
# TOTAL: 13
# PASS:  7
# SKIP:  6
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================

Do you have anything special in your make.conf / src.conf? Are you running GENERIC kernel?
Comment 6 Terry Kennedy 2017-06-28 03:05:21 UTC
(In reply to Renato Botelho from comment #5)

On the FreeBSD 11 system, it is 11-STABLE amd64 r318563 with no /etc/make.conf (not even an empty file). No /etc/src.conf either. The compiler is the system cc (tags/RELEASE_400/final 297347). No LLVM / clang from ports.

On the FreeBSD 10.3 system, it is 10-STABLE amd64 r316646 with nothing relevant in /etc/make.conf (only DEFAULT_VERSIONS+= for apache and php) and no /etc/src.conf. Likewise, system cc (tags/RELEASE_34/dot1-final 208032) and no LLVM / clang from ports.

If you would like root access to a 11-STABLE showing the problem, I can set that up for you.
Comment 7 Terry Kennedy 2017-06-28 03:07:03 UTC
I forgot to add - both boxes are using the GENERIC kernel, built locally from SVN at the indicated revisions.
Comment 8 Renato Botelho freebsd_committer freebsd_triage 2017-07-03 17:12:57 UTC
There are more people seeing this and there is an open ticket on Clamav bugtracker - https://bugzilla.clamav.net/show_bug.cgi?id=11742
Comment 9 Terry Kennedy 2017-07-03 22:30:20 UTC
(In reply to Renato Botelho from comment #8)

I saw that bug some time ago and tried the suggested changes without any improvement. There are also some Linux bug reports that claim it is due to a version bump in zlib. It all seems a bit "throw stuff at it and see what sticks".

Whad is odd is that the same base version of clamav (0.99.2) used to build fine, but something changed elsewhere on my FreeBSD systems which causes the test to fail - the 0.99.2_2 (r420045) port passed the tests when it was originally built (on an older kernel + world + other ports) but even that version of the port no longer passes the test with an up-to-date system.

So, while there may indeed be problematic code in clamav, that does not seem to be the trigger in this case.

Can you compare installed ports / versions on your system with my system?
Comment 10 Renato Botelho freebsd_committer freebsd_triage 2017-08-16 10:29:48 UTC
Over to new maintainer
Comment 11 Walter Schwarzenfeld freebsd_triage 2018-01-23 16:52:50 UTC
Created attachment 190004 [details]
svn-diff-clamav-test
Comment 12 Walter Schwarzenfeld freebsd_triage 2018-01-23 16:53:40 UTC
Take the patches from the upstream link an packed it in a svn-diff. Compiles fine with TEST=on on 10.4 and 11.1.
Comment 14 Terry Kennedy 2018-03-03 02:22:08 UTC
(In reply to w.schwarzenfeld from comment #13)

Seems to work fine. Ok to close if no-one else reports any issues.

Thanks!