Bug 219201 - [patch] sysutils/bareos-server readline isn't being found by configure
Summary: [patch] sysutils/bareos-server readline isn't being found by configure
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jose Alonso Cardenas Marquez
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-05-10 21:54 UTC by rand
Modified: 2017-07-07 02:25 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (acm)


Attachments
Patch to correctly locate the readline tool (439 bytes, patch)
2017-05-10 21:54 UTC, rand
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description rand 2017-05-10 21:54:59 UTC
Created attachment 182489 [details]
Patch to correctly locate the readline tool

The configure script with Bareos is only looking in /usr/include for readline when "--with-readline=yes" is specified:

checking /usr/include/readline/readline.h usability... no
checking /usr/include/readline/readline.h presence... no
checking for /usr/include/readline/readline.h... no

With the trivial change to the Makefile (really trivial patch attached) of using "--with-readline=${PREFIX}" readline is correctly located and included:

checking /usr/local/include/readline/readline.h usability... yes
checking /usr/local/include/readline/readline.h presence... yes
checking for /usr/local/include/readline/readline.h... yes

This makes the bconsole command much nicer to use.
Comment 1 commit-hook freebsd_committer 2017-07-07 02:20:26 UTC
A commit references this bug:

Author: acm
Date: Fri Jul  7 02:19:22 UTC 2017
New revision: 445197
URL: https://svnweb.freebsd.org/changeset/ports/445197

Log:
  - Update to 16.2.6
  - Fix readline detection [1]

  PR:             219201 [1]
  Submitted by:   rand at iteris.com [1]

Changes:
  head/sysutils/bareos-client/Makefile
  head/sysutils/bareos-client-static/Makefile
  head/sysutils/bareos-docs/Makefile
  head/sysutils/bareos-docs/distinfo
  head/sysutils/bareos-server/Makefile
  head/sysutils/bareos-server/distinfo