Created attachment 182529 [details] shar New cryptographic hash implementations from google. https://github.com/google/highwayhash
Assignee timeout. Give back to the pool.
Builds in poudriere.
Created attachment 185010 [details] shar QAs: * poudriere * portlint
Few things here, * PORTVERSION with github tag should be date with a g, ex. g20170811. * The patch-Makefile could be made into a REINPLACE_CMD in post-patch target. * Libs need stripped * Port fails to build in i386.
Created attachment 185300 [details] shar > * PORTVERSION with github tag should be date with a g, ex. g20170811. > * The patch-Makefile could be made into a REINPLACE_CMD in post-patch target. > * Libs need stripped Fixed > * Port fails to build in i386. Not supported on i386 yet. Added ONLY_FOR_ARCHS. Please ignore portlint warning about CHMOD - it just corrects permissions, and will go away when upstream fixes bugs related to install flags.
* Instead of changing the install perms in Makefile, why not change it to ${INSTALL_LIB}. This should take care of the perms and stripping. * Also, ONLY_FOR_ARCHS* should be after the license section and before the *_DEPENDS section.
Created attachment 185301 [details] shar > * Instead of changing the install perms in Makefile, why not change it to ${INSTALL_LIB}. This should take care of the perms and stripping. Because they do install it, just permissions are wrong. I asked them to fix permissions upstream, and to preserve symlinks. Once they do, these lines will just disappear. In the mean time, these lines just correct what they did wrong. > * Also, ONLY_FOR_ARCHS* should be after the license section and before the *_DEPENDS section. You need to submit this bug to ports-mgmt/portlint. portlint checks the order, and it currently doesn't complain. I moved the section.
bug #221377 There is already a patch just waiting for approval. I think the perm problem is acceptable if your getting fixed upstream. I'll take another look at it later if I have time. Thanks for your contributions.
(In reply to Richard Gallamore from comment #8) Thanks!
Can you also request upstream to implement the patch-highwayhash_os__specific.cc patch?
Created attachment 185326 [details] shar archive Actually, somebody already committed this patch upstream. Removed from port.
A commit references this bug: Author: ultima Date: Sun Aug 13 22:35:19 UTC 2017 New revision: 447922 URL: https://svnweb.freebsd.org/changeset/ports/447922 Log: Strong (well-distributed and unpredictable) hashes: * Portable implementation of SipHash * HighwayHash, a 5x faster SIMD hash with security claims WWW: https://github.com/google/highwayhash PR: 219232 Submitted by: Yuri Victorovich (maintainer) Reviewed by: matthew (mentor) Approved by: matthew (mentor) Differential Revision: https://reviews.freebsd.org/D12002 Changes: head/security/Makefile head/security/highwayhash/ head/security/highwayhash/Makefile head/security/highwayhash/distinfo head/security/highwayhash/files/ head/security/highwayhash/files/patch-highwayhash_os__specific.cc head/security/highwayhash/pkg-descr head/security/highwayhash/pkg-plist head/security/highwayhash/tags
(In reply to Yuri Victorovich from comment #11) I already had this in que for commit. Please open a new PR for update with the changes. Committed, thanks!