Bug 219257 - [MAINTAINER] japanese/mh: Fix compilation error on 12.0-CURRENT
Summary: [MAINTAINER] japanese/mh: Fix compilation error on 12.0-CURRENT
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Bartek Rutkowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-13 13:20 UTC by WATANABE Kazuhiro
Modified: 2017-08-17 12:25 UTC (History)
1 user (show)

See Also:


Attachments
poudriere testport log on 12.0-CURRENT without the patch (651.04 KB, text/plain)
2017-05-13 13:20 UTC, WATANABE Kazuhiro
no flags Details
poudriere testport log on 12.0-CURRENT with the patch (660.01 KB, text/plain)
2017-05-13 13:21 UTC, WATANABE Kazuhiro
no flags Details
A svn diff for japanese/mh (835 bytes, patch)
2017-05-13 13:23 UTC, WATANABE Kazuhiro
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WATANABE Kazuhiro 2017-05-13 13:20:51 UTC
Created attachment 182565 [details]
poudriere testport log on 12.0-CURRENT without the patch

On recent 12.0-CURRENT, japanese/mh has failed to build.
It has been occurred with a creation failure of config/version.c.
config/version.c is created with the config/version.sh script.

The version.sh script changes its IFS (Input Field Separators) variable
in the middle of the script from the default value (space, tab, and newline)
to ":".

After some command execution, it restore the IFS variable from ":" to " "
(not the default value).  It should be restored to the default value
for usual operation.  But the script doesn't do it, and has caused
odd behavior with recent 12.0-CURRENT (after r317559?).

To solve the problem, restore the IFS variable to the default value
appropriately.

* Simplified test script (from config/version.sh)

$ OFS="$IFS" IFS=:
$ LOCAL=`hostname`
$ IFS=" "                               # Should be 'IFS="$OFS"'
$ echo ' ('$LOCAL') of '`date`'";'

** Result on 12.0-CURRENT (r318250) - Bad.

 (aquarius-vm.sign.local) of Sat May 13 17:30:47 JST 2017
";

** Result on 10.3-RELEASE-p19 - Not bad.

 (aquarius-vm.sign.local) of Sat May 13 17:44:10 JST 2017";
Comment 1 WATANABE Kazuhiro 2017-05-13 13:21:59 UTC
Created attachment 182566 [details]
poudriere testport log on 12.0-CURRENT with the patch
Comment 2 WATANABE Kazuhiro 2017-05-13 13:23:12 UTC
Created attachment 182567 [details]
A svn diff for japanese/mh
Comment 3 commit-hook freebsd_committer 2017-08-17 12:17:20 UTC
A commit references this bug:

Author: robak
Date: Thu Aug 17 12:16:44 UTC 2017
New revision: 448088
URL: https://svnweb.freebsd.org/changeset/ports/448088

Log:
  japanese/mh: fix builds on 12-CURRENT

  PR:		219257
  Submitted by:	Watanabe Kazuhiro <CQG00620@nifty.ne.jp> (maintainer)
  MFH:		2017Q3

Changes:
  head/japanese/mh/Makefile
  head/japanese/mh/files/patch-config_version.sh
Comment 4 Bartek Rutkowski freebsd_committer 2017-08-17 12:25:50 UTC
Committed, thanks!