brainz.cpp: In member function 'void Brainz::processTillAnswer()': brainz.cpp:140:24: error: cannot convert 'bool' to 'bool*' in assignment Outputs[i].output = false; ^~~~~ build log: http://sprunge.us/eeKR
Created attachment 184796 [details] Proposed patch The attached patch fixes an actual bug in the code and lets it build with GCC 6.
A commit references this bug: Author: rakuco Date: Sun Aug 13 11:04:07 UTC 2017 New revision: 447874 URL: https://svnweb.freebsd.org/changeset/ports/447874 Log: Add patch to fix a wrong assignment in the code. In addition to fixing an actual bug, this also allows the port to build with GCC 6: brainz.cpp: In member function 'void Brainz::processTillAnswer()': brainz.cpp:140:24: error: cannot convert 'bool' to 'bool*' in assignment Outputs[i].output = false; PR: 219287 Approved by: maintainer timeout (amdmi3, 16 days) MFH: 2017Q3 Changes: head/games/critterding/files/patch-src_brainz_brainz.cpp
A commit references this bug: Author: rakuco Date: Sun Aug 13 11:05:25 UTC 2017 New revision: 447875 URL: https://svnweb.freebsd.org/changeset/ports/447875 Log: Bump PORTREVISION after r447874. The new patch changes the code, this should have been committed together with the previous change. PR: 219287 MFH: 2017Q3 Changes: head/games/critterding/Makefile
A commit references this bug: Author: rakuco Date: Thu Aug 17 15:58:55 UTC 2017 New revision: 448133 URL: https://svnweb.freebsd.org/changeset/ports/448133 Log: MFH: r447874 Add patch to fix a wrong assignment in the code. In addition to fixing an actual bug, this also allows the port to build with GCC 6: brainz.cpp: In member function 'void Brainz::processTillAnswer()': brainz.cpp:140:24: error: cannot convert 'bool' to 'bool*' in assignment Outputs[i].output = false; PR: 219287 Approved by: maintainer timeout (amdmi3, 16 days) Approved by: ports-secteam (feld) Changes: _U branches/2017Q3/ branches/2017Q3/games/critterding/files/patch-src_brainz_brainz.cpp
A commit references this bug: Author: rakuco Date: Thu Aug 17 16:00:06 UTC 2017 New revision: 448134 URL: https://svnweb.freebsd.org/changeset/ports/448134 Log: MFH: r447875 Bump PORTREVISION after r447874. The new patch changes the code, this should have been committed together with the previous change. PR: 219287 Approved by: ports-secteam (feld) Changes: _U branches/2017Q3/ branches/2017Q3/games/critterding/Makefile
I don't think this should be actually merger quarterly. The issue only presents itself when the default is switched to GCC 6 -- which really does not make sense on a quartlerly branch.