Bug 219324 - net/py-libnet: Limit to 2.x (Does not work with Python 3)
Summary: net/py-libnet: Limit to 2.x (Does not work with Python 3)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kubilay Kocak
URL:
Keywords: needs-patch
Depends on:
Blocks:
 
Reported: 2017-05-16 10:24 UTC by Johannes Jost Meixner
Modified: 2017-08-19 11:44 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (sbz)
koobs: merge-quarterly+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Jost Meixner freebsd_committer freebsd_triage 2017-05-16 10:24:02 UTC
net/py-libnet contains syntax that does not work with Python 3.x.

Please change to USES= python:2 and consider using autoplist instead of pkg-plist.

Also it might be a good idea to use a commithash from 2014 instead of 2011 :-)
Comment 1 Johannes Jost Meixner freebsd_committer freebsd_triage 2017-07-28 04:19:18 UTC
Throw back into bugs pool (maintainer timeout)
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-08-19 11:22:15 UTC
A commit references this bug:

Author: koobs
Date: Sat Aug 19 11:21:59 UTC 2017
New revision: 448299
URL: https://svnweb.freebsd.org/changeset/ports/448299

Log:
  net/py-libnet: Limit to 2.x (Does not support Python 3)

  This (upstream) package does not appear to support (intentionally or otherwise)
  Python 3. It also fails to build with Python 3.x with a SyntaxError.

  This change corrects the USES=python:<version-spec> support declaration
  accordingly.

  PR:		219324
  Reported by:	Johannes Jost Meixner
  Approved by:	portmgr (blanket)
  MFH:		2017Q3

Changes:
  head/net/py-libnet/Makefile
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-08-19 11:27:21 UTC
A commit references this bug:

Author: koobs
Date: Sat Aug 19 11:26:50 UTC 2017
New revision: 448300
URL: https://svnweb.freebsd.org/changeset/ports/448300

Log:
  MFH: r448299

  net/py-libnet: Limit to 2.x (Does not support Python 3)

  This (upstream) package does not appear to support (intentionally or otherwise)
  Python 3. It also fails to build with Python 3.x with a SyntaxError.

  This change corrects the USES=python:<version-spec> support declaration
  accordingly.

  PR:		219324
  Reported by:	Johannes Jost Meixner
  Approved by:	portmgr (blanket)

  Approved by:	ports-secteam (blanket)

Changes:
_U  branches/2017Q3/
  branches/2017Q3/net/py-libnet/Makefile
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2017-08-19 11:44:29 UTC
Merged and committed, thank you for your report Johannes.

Additional notes:

- Appears PyPI name is pylibnet which has a 3.0rc1 sdist (rename port accordingly)
- pythonprefix probably not required. autoplist appears to work fine after removing it, do-install: target (and minor pkg-plist modification).
- Version in current commit hash code is 3.0rc1 (not 1.1)
- setup.py patch probably not required with next upstream commit (hash). Needs confirmation

These changes should be made in a separate issue/review (I have them in my local tree