Bug 219360 - [ports-mgmt/portlint] [patch] JAVALIBDIR check is broken since 2.17.0
Summary: [ports-mgmt/portlint] [patch] JAVALIBDIR check is broken since 2.17.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Joe Marcus Clarke
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-05-17 17:49 UTC by Eugene Grosbein
Modified: 2017-06-04 22:31 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (marcus)


Attachments
unbreak test for JAVALIBDIR (996 bytes, patch)
2017-05-17 17:49 UTC, Eugene Grosbein
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Grosbein freebsd_committer freebsd_triage 2017-05-17 17:49:52 UTC
Created attachment 182673 [details]
unbreak test for JAVALIBDIR

portlint version 2.17.0 introduced variables expansion on all sides of the dependency tuple. As a result, ${JAVALIBDIR} gets expanded and, so later check for its value produces false FATAL error.

How-to-Repeat:

$ portlint /usr/ports/java/bouncycastle15 
FATAL: Makefile: you should use ${JAVALIBDIR} in BUILD_DEPENDS/RUN_DEPENDS to define dependencies on JAR files installed in ${JAVAJARDIR}

Proposed fix moves the check for JAVALIBDIR before expansion code.
Comment 1 Eugene Grosbein freebsd_committer freebsd_triage 2017-06-02 18:46:00 UTC
Hi!

Please look at this PR containing fix for portlint. Would you like me to commit the fix myself in form of distinct patch in files/ directory or direct change to ports-mgmt/portlint/src/portlint.pl ? I've already got it approved by my mentor and going to commit this weekend if no objections from your side.
Comment 2 Joe Marcus Clarke freebsd_committer freebsd_triage 2017-06-02 18:55:35 UTC
I will commit this to my local repo where I aggregate changes into a release.  I expect I can do a release this weekend.
Comment 3 Joe Marcus Clarke freebsd_committer freebsd_triage 2017-06-04 22:31:12 UTC
Fixed in 2.17.9.