Bug 219389 - x11-wm/awesome: CONFLICT vars should contain package names
Summary: x11-wm/awesome: CONFLICT vars should contain package names
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Renato Botelho
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-18 18:54 UTC by Pawel Pekala
Modified: 2017-05-18 21:21 UTC (History)
0 users

See Also:
garga: maintainer-feedback+


Attachments
CONFLICTS fix (788 bytes, patch)
2017-05-18 18:54 UTC, Pawel Pekala
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pawel Pekala freebsd_committer freebsd_triage 2017-05-18 18:54:09 UTC
Created attachment 182713 [details]
CONFLICTS fix

Fix CONFLICTS_INSTALL variables to contain packages names instead of
ports origins. While origins work fine this is against what Porters
Handbook advises.
Comment 1 Renato Botelho freebsd_committer freebsd_triage 2017-05-18 20:54:01 UTC
Looks good to me. Please go ahead and get it committed.
Comment 2 Pawel Pekala freebsd_committer freebsd_triage 2017-05-18 21:20:54 UTC
Committed, thanks!
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-05-18 21:21:19 UTC
A commit references this bug:

Author: pawel
Date: Thu May 18 21:20:30 UTC 2017
New revision: 441201
URL: https://svnweb.freebsd.org/changeset/ports/441201

Log:
  Fix CONFLICTS_INSTALL variables to contain packages names instead of
  ports origins. While origins work fine this is against what Porter's
  Handbook advises.

  PR:		219389
  Submitted by:	myself
  Approved by:	garga (maintainer)

Changes:
  head/x11-wm/awesome/Makefile
  head/x11-wm/awesome3/Makefile