Bug 219455 - [patch] fix build of devel/talloc on powerpc64
Summary: [patch] fix build of devel/talloc on powerpc64
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: powerpc Any
: --- Affects Some People
Assignee: Justin Hibbits
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-05-22 12:08 UTC by Mark Linimon
Modified: 2017-06-20 00:00 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (timur)


Attachments
patch to devel/talloc/Makefile (414 bytes, patch)
2017-05-22 12:08 UTC, Mark Linimon
no flags Details | Diff
new patchfile to add into devel/talloc/files/ (494 bytes, patch)
2017-05-22 12:09 UTC, Mark Linimon
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Linimon freebsd_committer freebsd_triage 2017-05-22 12:08:04 UTC
Created attachment 182801 [details]
patch to devel/talloc/Makefile

This patch fixes the build of devel/talloc on powerpc64.  It may also fix the build on other archs that do not have llvm in base (not yet tested).

Build-tested on powerpc64; tested for no-effect on amd64 via 'make patch'.
Comment 1 Mark Linimon freebsd_committer freebsd_triage 2017-05-22 12:09:28 UTC
Created attachment 182802 [details]
new patchfile to add into devel/talloc/files/
Comment 2 Steve Wills freebsd_committer freebsd_triage 2017-06-15 15:04:53 UTC
Just for the record, I can confirm this does fix the build
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-06-17 20:00:09 UTC
A commit references this bug:

Author: jhibbits
Date: Sat Jun 17 19:59:31 UTC 2017
New revision: 443785
URL: https://svnweb.freebsd.org/changeset/ports/443785

Log:
  Fix build of devel/talloc on powerpc and powerpc64

  Base gcc doesn't accept -Wno-format-length.  Remove its usage on powerpc and
  powerpc64.  It could probably be generalized to all gcc-based targets, but that
  hasn't been tested on other architectures.

  PR:		219455
  Submitted by:	linimon
  Approved by:	swills

Changes:
  head/devel/talloc/Makefile
  head/devel/talloc/files/powerpc-patch-lib_replace_wscript