Bug 219501 - net-mgmt/softflowd: update to 0.9.9_1
Summary: net-mgmt/softflowd: update to 0.9.9_1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jochen Neumeister
URL:
Keywords: patch-ready
Depends on:
Blocks:
 
Reported: 2017-05-24 12:18 UTC by Paul Godard
Modified: 2017-06-03 18:45 UTC (History)
2 users (show)

See Also:
jmohacsi: maintainer-feedback+

Attachments
softflowd-0.9.9_1.diff (2.09 KB, patch)
2017-05-24 12:18 UTC, Paul Godard 		no flags Details | Diff
softflowd-0.9.9_1.diff (1.99 KB, patch)
2017-05-29 21:20 UTC, Paul Godard 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Godard 2017-05-24 12:18:00 UTC 
Created attachment 182861 [details]
softflowd-0.9.9_1.diff

New port revision (0.9.9_1)

- Update to latest 0.9.9 version as found on irino's GitHub repot (the original author of softflowd - Damien Miller - indicated that the current active repo to use should be irino's GitHub repo)
- Includes a lot of work by Hitoshi Irino to implement IPFIX
- Includes native support for the pflog datalink type (thus no longer needing a FreeBSD specific patch)
- Includes single instance checking (multiple instances can execute when using different pid files)
Comment 1 Janos Mohacsi 2017-05-25 15:42:06 UTC 
Approved
Comment 2 Jochen Neumeister freebsd_committer freebsd_triage 2017-05-26 09:38:32 UTC 
(In reply to Paul Godard from comment #0)

Hi Paul,

i see, you will delete the patch softflowd.c
Can you tell me, why?
I test the patch with this port, and it works fine: http://joneumbox.org/data/12amd64-ports/2017-05-26_11h35m46s/logs/softflowd-0.9.9_1.log
Comment 3 Paul Godard 2017-05-26 11:21:25 UTC 
Hi Jochen,

I'm removing the patch file only to clean up the port and because the patch is no longer required. The softflowd.c patch added support for the pflog datalink type; that's no longer required as it's now natively part of softflowd (take a look at the following commit https://github.com/irino/softflowd/commit/b7e50ae4ebb3368a52c7938e1d2b046f90cf6d8f).

Thanks,
Paul
Comment 4 Jochen Neumeister freebsd_committer freebsd_triage 2017-05-28 16:41:01 UTC 
USE_AUTOTOOLS=        autoconf
USE_AUTOTOOLS=        autoheader

It is more readable to put these two autotools USES on one line.

Or even better, can you convert this to USES=autoreconf and if needed add GNU_CONFIGURE=yes
Comment 5 Paul Godard 2017-05-29 21:17:35 UTC 
(In reply to Jochen Neumeister from comment #4)

I've tested using "USES=autoreconf" as opposed to the two "USE_AUTOTOOLS" directives; I can confirm that this works just fine.

Updating diff file to reflect proposed Makefile changes.
Comment 6 Paul Godard 2017-05-29 21:20:43 UTC 
Created attachment 183040 [details]
softflowd-0.9.9_1.diff

Added "autoreconf" to the "USES" directive and removed the two "USE_AUTOTOOLS" directives as per suggestion
Comment 7 commit-hook freebsd_committer freebsd_triage 2017-06-03 18:42:00 UTC 
A commit references this bug:

Author: joneum
Date: Sat Jun  3 18:41:03 UTC 2017
New revision: 442513
URL: https://svnweb.freebsd.org/changeset/ports/442513

Log:
  - Set USES: autoreconf
  - Switch to GitHub
  - Bump PORTREVISION

  PR:		219501
  Reported by:	Paul Godard
  Approved by:	jmohacsi@bsd.hu (maintainer) miwi (mentor)
  Differential Revision:	https://reviews.freebsd.org/D10961

Changes:
  head/net-mgmt/softflowd/Makefile
  head/net-mgmt/softflowd/distinfo
  head/net-mgmt/softflowd/files/patch-softflowd.c
Comment 8 Jochen Neumeister freebsd_committer freebsd_triage 2017-06-03 18:45:09 UTC 
Committed, thanks :-)