Bug 219548 - print/cups-filters: Always specify pdftops path
Summary: print/cups-filters: Always specify pdftops path
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Tijl Coosemans
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-25 19:15 UTC by Albert Ou
Modified: 2017-05-26 09:00 UTC (History)
1 user (show)

See Also:
cyberbotx: maintainer-feedback+


Attachments
Patch to always specify --with-pdftops-path (1.11 KB, patch)
2017-05-25 19:15 UTC, Albert Ou
no flags Details | Diff
configure log (103.68 KB, text/plain)
2017-05-25 19:17 UTC, Albert Ou
no flags Details
poudriere build log (32.67 KB, text/plain)
2017-05-25 19:18 UTC, Albert Ou
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Albert Ou 2017-05-25 19:15:56 UTC
Created attachment 182903 [details]
Patch to always specify --with-pdftops-path

Building with the MUPDF option fails at the configure phase:

configure:19994: checking for pdftops                                                                                                                                                                                                                                                                                         
configure:20024: result: no                                                                                                                                                                                                                                                                                                   
configure:20033: error: Required pdftops is missing. Please install the pdftops utility of Poppler.

The configure script unconditionally checks for pdftops(1) regardless of which PDF-to-PostScript renderer is selected (--with-pdftops).  It is therefore necessary to always pass --with-pdftops-path; otherwise, the path will default to /usr/bin/pdftops, which is of course non-existent.
Comment 1 Albert Ou 2017-05-25 19:17:46 UTC
Created attachment 182904 [details]
configure log
Comment 2 Albert Ou 2017-05-25 19:18:22 UTC
Created attachment 182905 [details]
poudriere build log
Comment 3 Naram Qashat 2017-05-25 20:37:28 UTC
Patch looks fine to me.
Comment 4 commit-hook freebsd_committer 2017-05-26 08:42:48 UTC
A commit references this bug:

Author: tijl
Date: Fri May 26 08:41:48 UTC 2017
New revision: 441762
URL: https://svnweb.freebsd.org/changeset/ports/441762

Log:
  Always specify --with-pdftops-path to fix build with MUPDF option.

  PR:		219548
  Submitted by:	Albert Ou <aou@eecs.berkeley.edu>
  Approved by:	Naram Qashat <cyberbotx@cyberbotx.com> (maintainer)

Changes:
  head/print/cups-filters/Makefile