Bug 219550 - Add support for Open+LayoutGet RPC to the NFSv4.1/pNFS client
Summary: Add support for Open+LayoutGet RPC to the NFSv4.1/pNFS client
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Rick Macklem
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-25 20:08 UTC by Rick Macklem
Modified: 2019-01-21 22:52 UTC (History)
2 users (show)

See Also:
rmacklem: mfc-stable12+


Attachments
add Open+LayoutGet RPCs (37.91 KB, patch)
2017-05-25 20:08 UTC, Rick Macklem
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rick Macklem freebsd_committer freebsd_triage 2017-05-25 20:08:58 UTC
Created attachment 182908 [details]
add Open+LayoutGet RPCs

This patch adds support for Open+LayoutGet RPCs to the NFSv4.1/pNFS client,
reducing the RPC count by avoiding a separate RPC for LayoutGet.
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-06-24 20:01:48 UTC
A commit references this bug:

Author: rmacklem
Date: Sat Jun 24 20:01:22 UTC 2017
New revision: 320322
URL: https://svnweb.freebsd.org/changeset/base/320322

Log:
  Add two new compound RPCs to the NFSv4.1/pNFS client.

  When the NFSv4.1 client is doing pNFS, it needs to get an Open and
  a Layout for every file it will be doing I/O on. The current code
  does two separate RPCs to get these. This patch adds two new compounds
  that do the both the Open and LayoutGet in the same RPC, reducing the
  RPC count.
  It also factors out the code that sets up and parses the LayoutGet operation
  into separate functions, so that the code doesn't get duplicated for
  these new RPCs.
  This patch is fairly large, but should only affect the NFSv4.1 client
  when the "pnfs" option is specified.

  PR:		219550
  MFC after:	2 weeks

Changes:
  head/sys/fs/nfs/nfs_commonsubs.c
  head/sys/fs/nfs/nfsport.h
  head/sys/fs/nfs/nfsproto.h
  head/sys/fs/nfsclient/nfs_clcomsubs.c
  head/sys/fs/nfsclient/nfs_clrpcops.c
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-06-24 20:09:56 UTC
A commit references this bug:

Author: rmacklem
Date: Sat Jun 24 20:09:23 UTC 2017
New revision: 320323
URL: https://svnweb.freebsd.org/changeset/base/320323

Log:
  Add RPC count reporting for the two new RPCs added by r320322.

  This is a content change.

  PR:		219550
  MFC after:	2 weeks

Changes:
  head/usr.bin/nfsstat/nfsstat.c
Comment 3 Oleksandr Tymoshenko freebsd_committer freebsd_triage 2019-01-21 19:34:53 UTC
Rick, can this PR be closed now or is there work still pending?

Thanks
Comment 4 Rick Macklem freebsd_committer freebsd_triage 2019-01-21 22:52:44 UTC
Patch has been committed and MFC'd.