Bug 219761 - [patch] lang/spidermonkey17 blocks polkit from from building
Summary: [patch] lang/spidermonkey17 blocks polkit from from building
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Koop Mast
Keywords: patch
Depends on:
Reported: 2017-06-03 20:51 UTC by Koop Mast
Modified: 2017-07-30 14:41 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (citric)
kwm: maintainer-feedback?

Move SM 1.7 headers (4.12 KB, patch)
2017-06-03 20:51 UTC, Koop Mast
no flags Details | Diff
[patch] alternate patch - put js cflags first (workaround for polkit only) (3.05 KB, patch)
2017-06-05 09:04 UTC, John Hein
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Koop Mast freebsd_committer 2017-06-03 20:51:27 UTC
Created attachment 183185 [details]
Move SM 1.7 headers

When installed Spidermonkey 1.7's headers will be picked up by software using other spidermonkey versions. This is because the build will first look in ${LOCALBASE}/include before looking into the spidermonkey specific subdir for the headers. In my case sysutils/polkit, see the linked bugs.

To fix this, move the headers to there own subdir in ${LOCALBASE}/include, and fix the users of spidermonkey 1.7 to look into this dir.
Comment 1 Koop Mast freebsd_committer 2017-06-03 20:52:02 UTC
Comment 2 John Hein 2017-06-05 09:04:52 UTC
Created attachment 183235 [details]
[patch] alternate patch - put js cflags first (workaround for polkit only)

Here's a patch I had.  It's a simple patch - puts the javascript cflags before the other flags.
Comment 3 Koop Mast freebsd_committer 2017-06-05 09:14:47 UTC
I prefer my spidermonkey17 patch. As it fixes the root of the problem, this way not only is polkit fixed. Other software that uses spidermonkey headers won't potential have the same issue.
Comment 4 John Hein 2017-06-05 13:18:17 UTC
Comment on attachment 183235 [details]
[patch] alternate patch - put js cflags first (workaround for polkit only)

(In reply to Koop Mast from comment #3)
Agreed your patch is a better long term solution than my quick fix which just gets polkit building.
Comment 5 commit-hook freebsd_committer 2017-07-30 14:35:26 UTC
A commit references this bug:

Author: kwm
Date: Sun Jul 30 14:34:28 UTC 2017
New revision: 446936
URL: https://svnweb.freebsd.org/changeset/ports/446936

  Move spidermonkey17's headers out of LOCALBASE and in there own subdir. [1]

  This fixes build issues with other spidermonkey using ports when
  SM 1.7 is installed, due to SM 1.7's headers being found first. [2]

  Update SM 1.7 users to take this change into account.

  PR:		219761 [1], 214724 [2], 202246 [2]
  Approved by:	maintainer timeout (nearly 2 months)