Bug 219812 - finance/py-python-obelisk: Update py-twisted dependency
Summary: finance/py-python-obelisk: Update py-twisted dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Alan Somers
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2017-06-06 03:51 UTC by Alan Somers
Modified: 2017-06-11 03:39 UTC (History)
2 users (show)

See Also:
asomers: maintainer-feedback?


Attachments
Updated twisted dependency (736 bytes, patch)
2017-06-06 03:51 UTC, Alan Somers
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Somers freebsd_committer 2017-06-06 03:51:40 UTC
Created attachment 183253 [details]
Updated twisted dependency

The old py-twistedCore port is obsolete.  It's been replaced by py-twisted.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2017-06-06 04:55:42 UTC
Reporter is committer, assign accordingly.

Please assign yourself where you are a reporter/committer and maintainer is not as it saves triager time classifying and reduces freebsd-ports-bugs noise
Comment 2 Sunpoet Po-Chuan Hsieh freebsd_committer 2017-06-06 14:44:44 UTC
FYI, I'm also working on the removal of old Twisted.
Comment 3 Alan Somers freebsd_committer 2017-06-06 15:01:50 UTC
Yuri, can you please confirm whether you tried running the port with my patch, or  merely reviewed the diff?  All I've done is build test it.
Comment 4 Yuri Victorovich freebsd_committer 2017-06-06 15:28:42 UTC
Hi Alan,

py-python-obelisk doesn't define any tests, so there is no obvious way to test it. I also don't run any depending on it software, that would be some bitcoin software.

But the twisted change is just the merge of previously separate packages into one. The risk should be minimal.

Regards,
Yuri
Comment 5 commit-hook freebsd_committer 2017-06-11 03:37:57 UTC
A commit references this bug:

Author: asomers
Date: Sun Jun 11 03:36:55 UTC 2017
New revision: 443145
URL: https://svnweb.freebsd.org/changeset/ports/443145

Log:
  finance/py-python-obelisk: Update py-twisted dependency

  PR:		219812
  Approved by:	Yuri Victorovich <yuri@rawbw.com> (maintainer)
  Approved by:	brd (ports)

Changes:
  head/finance/py-python-obelisk/Makefile