Bug 219813 - x11-toolkits/wxgtk30: Fails to build with GCC
Summary: x11-toolkits/wxgtk30: Fails to build with GCC
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: needs-qa
Depends on:
Blocks:
 
Reported: 2017-06-06 04:52 UTC by Jack
Modified: 2018-01-31 20:25 UTC (History)
2 users (show)

See Also:
koobs: maintainer-feedback? (portmaster)
koobs: merge-quarterly?


Attachments
Patch to allow ports built with gcc to warn about C++ ABI instead of fatal error (558 bytes, text/x-c++src)
2017-06-06 05:04 UTC, Jack
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jack 2017-06-06 04:52:49 UTC
ports built with gcc instead of clang will fail to start with a fatal error:

Fatal Error: Mismatch between the program and library build versions detected.
The library used 3.0 (wchar_t,compiler with C++ ABI 1002,wx containers,compatible with 2.6,compatible with 2.8),
and your program used 3.0 (wchar_t,compiler with C++ ABI 1009,wx containers,compatible with 2.6,compatible with 2.8).
Abort (core dumped)

This patch changes the fatal error to a warning to allow the programs to still function.

root@upstairs:/usr/ports/x11-toolkits/wxgtk30 # svn diff
Index: files/patch-src-common-appbase.cpp
===================================================================
--- files/patch-src-common-appbase.cpp  (nonexistent)
+++ files/patch-src-common-appbase.cpp  (working copy)
@@ -0,0 +1,15 @@
+--- src/common/appbase.cpp.orig        2014-10-06 14:33:44.000000000 -0700
++++ src/common/appbase.cpp     2017-06-05 21:16:18.988544000 -0700
+@@ -762,10 +762,10 @@
+         msg.Printf(wxT("Mismatch between the program and library build versions detected.\nThe library used %s,\nand %s used %s."),
+                    lib.c_str(), progName.c_str(), prog.c_str());
+ 
+-        wxLogFatalError(msg.c_str());
++        wxLogWarning(msg.c_str());
+ 
+         // normally wxLogFatalError doesn't return
+-        return false;
++        //return false;
+     }
+ 
+     return true;
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2017-06-06 04:58:38 UTC
Thank you for your report Jack.

Use "category/portname: Summary" so that issues automatically get automatically assigned and notify their maintainers.

Please also include the patch in the description as an attachment
Comment 2 Jack 2017-06-06 05:04:31 UTC
Created attachment 183255 [details]
Patch to allow ports built with gcc to warn about C++ ABI instead of fatal error
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2017-06-16 11:51:03 UTC
I don't think it's safe. We've had a lot of crashes with clang wx/gcc apps before, and it's better to have this error instead of a crash. The only correct solution is to make everything c++ buildable with clang.
Comment 4 Walter Schwarzenfeld 2018-01-31 19:49:16 UTC
No feedback from submitter! Close?
Comment 5 Jack 2018-01-31 20:24:03 UTC
Looks like it's been fixed. ok to close.