Bug 219819 - "make clean all" is broken
Summary: "make clean all" is broken
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Bryan Drewery
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-06 09:20 UTC by Edward Tomasz Napierala
Modified: 2017-06-23 20:40 UTC (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Edward Tomasz Napierala freebsd_committer freebsd_triage 2017-06-06 09:20:50 UTC 
Doing "make clean all" in individual subdirectories is broken on 12-CURRENT: it doesn't run the "all".  For example:

[trasz@brick:~/svn/head]% cd usr.sbin/iscsid
[trasz@brick:~/svn/head/usr.sbin/iscsid]% make clean all install
rm -f iscsid iscsid.bc iscsid.ll iscsid.full iscsid.full.bc iscsid.debug iscsid.full.ll chap.o discovery.o iscsid.o keys.o log.o login.o pdu.o chap.bco discovery.bco iscsid.bco keys.bco log.bco login.bco pdu.bco chap.llo discovery.llo iscsid.llo keys.llo log.llo login.llo pdu.llo iscsid.8.gz iscsid.8.cat.gz
install  -s -o root -g wheel -m 555   iscsid /usr/sbin/iscsid
install: iscsid: No such file or directory
*** Error code 71

Stop.
make: stopped in /usr/home/trasz/svn/head/usr.sbin/iscsid
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-06-20 20:52:26 UTC 
A commit references this bug:

Author: bdrewery
Date: Tue Jun 20 20:52:07 UTC 2017
New revision: 320174
URL: https://svnweb.freebsd.org/changeset/base/320174

Log:
  Fix 'make clean all' to work again.

  This likely broke completely with r308599.

  Apply the same fix for 'make destroy' which is a DIRDEPS_BUILD thing.

  PR:		219819
  Reported by:	trasz
  MFC after:	3 days
  Sponsored by:	Dell EMC Isilon

Changes:
  head/share/mk/bsd.dep.mk
  head/share/mk/bsd.init.mk
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-06-23 20:39:03 UTC 
A commit references this bug:

Author: bdrewery
Date: Fri Jun 23 20:38:21 UTC 2017
New revision: 320298
URL: https://svnweb.freebsd.org/changeset/base/320298

Log:
  MFC r320174,r320204:

    r320174:
      Fix 'make clean all' to work again.
    r320204:
      Fix various 'make *clean *all *install' combinations.

  PR:		219819
  Approved by:	re (gjb)

Changes:
_U  stable/11/
  stable/11/share/mk/bsd.dep.mk
  stable/11/share/mk/bsd.init.mk
  stable/11/sys/conf/kern.post.mk