Bug 219884 - www/webgrind: Update to 1.5
Summary: www/webgrind: Update to 1.5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jochen Neumeister
URL:
Keywords: easy, needs-qa
Depends on:
Blocks:
 
Reported: 2017-06-09 06:34 UTC by Franco Fichtner
Modified: 2017-06-13 08:10 UTC (History)
2 users (show)

See Also:
koobs: maintainer-feedback? (franco)


Attachments
patch against head (1.61 KB, patch)
2017-06-09 06:34 UTC, Franco Fichtner
franco: maintainer-approval+
Details | Diff
patch (1.58 KB, patch)
2017-06-09 13:37 UTC, Jochen Neumeister
joneum: maintainer-approval? (franco)
Details | Diff
second try (2.03 KB, patch)
2017-06-09 15:55 UTC, Franco Fichtner
franco: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Franco Fichtner 2017-06-09 06:34:54 UTC
Created attachment 183352 [details]
patch against head
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2017-06-09 12:02:02 UTC
Thank you Franco, can you please confirm this change passes QA
Comment 2 Jochen Neumeister freebsd_committer 2017-06-09 13:27:24 UTC
Hey Franco,

why do you delete:
%%WWWDIR%%/license.txt
%%WWWDIR%%/package.sh

Now the port doesn't build:

====> Running Q/A tests (stage-qa)
====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: %%WWWDIR%%/license.txt
Error: Orphaned: %%WWWDIR%%/package.sh
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1

See: http://joneumbox.org/build.html?mastername=12amd64-ports&build=2017-06-09_15h21m11s
Comment 3 Jochen Neumeister freebsd_committer 2017-06-09 13:37:07 UTC
Created attachment 183359 [details]
patch

Hi franco,

this Patch works for me: http://joneumbox.org/build.html?mastername=12amd64-ports&build=2017-06-09_15h34m20s
Comment 4 Franco Fichtner 2017-06-09 15:55:22 UTC
Created attachment 183362 [details]
second try

Hi Jochen,

> why do you delete:

* license.txt is bundled with LICENSE_FILE
* package.sh is for creating the distfile

The whole tree is staged using COPYTREE_SHARE, it's not optimal as it catches files that shouldn't be packaged.  When I took over during the 1.4 update, I retained the current plist, but I wanted to clean it up this time.

> Now the port doesn't build:

* please add check-orphans to DEVELOPER=yes during the QA stage, otherwise it'll drain time and energy to report something obvious that the Framework could have told me right away
* check-orphans ignores ".orig" files, it indicates to me that it should not be mandatory for submitting / building

Poudriere is a nice tool for batch building/troubleshooting, but it gets in the way of submitting updates, especially for newcomers, amateurs, upstream maintainers maintaining their own ports, minor submits for correctness, etc.


Cheers,
Franco
Comment 5 commit-hook freebsd_committer 2017-06-13 08:09:42 UTC
A commit references this bug:

Author: joneum
Date: Tue Jun 13 08:09:36 UTC 2017
New revision: 443490
URL: https://svnweb.freebsd.org/changeset/ports/443490

Log:
  - www/webgrind: Update from 1.4.0 to 1.5.0
  - Changes:
    * Allow custom CSS
    * Miscellaneous bug fixes

  PR:		219884
  Submitted by:	Franco Fichtner (maintainer)
  Approved by:	miwi (mentor)
  Differential Revision:	https://reviews.freebsd.org/D11117

Changes:
  head/www/webgrind/Makefile
  head/www/webgrind/distinfo
  head/www/webgrind/pkg-plist
Comment 6 Jochen Neumeister freebsd_committer 2017-06-13 08:10:51 UTC
Committed, thanks :-)