Bug 219907 - astro/xephem: nroff: not found
Summary: astro/xephem: nroff: not found
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Josh Paetzel
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-10 13:56 UTC by O. Hartmann
Modified: 2017-06-12 20:32 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (jpaetzel)


Attachments
Patch against astro/xephem/Makefile for OSVERSION (449 bytes, patch)
2017-06-10 13:59 UTC, O. Hartmann
ohartmann: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description O. Hartmann 2017-06-10 13:56:35 UTC
The port astro/xephem fails to build on recent 12-CURRENT (12.0-CURRENT #39 r319759: Fri Jun  9 22:30:07 CEST 2017 amd64) with the error shown below.

I think this is a fallout due to the removement of GNU roff from the base system, see src/UPDATING, date tag 20170531.

The problem can be fixed by adding

BUILD_DEPENDS= nroff:textproc/groff

to the port's Makefile. A more sophisticated way would be a dependency on the OSVERSION

[...]
/bin/sh: nroff: not found
gmake[1]: *** [Makefile:195: xephem.1] Error 127
gmake[1]: Leaving directory '/wrkdirs/usr/ports/astro/xephem/work/xephem-3.7.7/GUI/xephem'
*** Error code 1
Comment 1 O. Hartmann 2017-06-10 13:59:23 UTC
Created attachment 183384 [details]
Patch against astro/xephem/Makefile for OSVERSION

The patch reels in textproc/groff for OSVERSION >= 1200032

According to src/UPDATING, GNU groff has been removed from base system. Port astro/xephem depends on nroff, which is not further available after the removement and so it has to be installed as a build time dependency.
Comment 2 Josh Paetzel freebsd_committer 2017-06-12 19:11:09 UTC
Was that patch actually tested?  It looks like it resets BUILD_DEPENDS.
Comment 3 Josh Paetzel freebsd_committer 2017-06-12 19:29:13 UTC
So if I set BUILD_DEPENDS+= textproc/groff

versus BUILD_DEPENDS= textproc/groff

The only difference between the two depends lists is that devel/gmake is included.

gmake gets pulled in by a dep, but is also needed for xephem.
Comment 4 commit-hook freebsd_committer 2017-06-12 19:55:57 UTC
A commit references this bug:

Author: jpaetzel
Date: Mon Jun 12 19:54:54 UTC 2017
New revision: 443463
URL: https://svnweb.freebsd.org/changeset/ports/443463

Log:
  Update port to work after removal of groff from the base system.

  PR:	219907
  Submitted by:	ohartmann@walstatt.org

Changes:
  head/astro/xephem/Makefile
Comment 5 O. Hartmann 2017-06-12 20:32:56 UTC
(In reply to Josh Paetzel from comment #3)

You're correct, my final version also had a "+" added. I tested the patch in a non-clean-from-scratch poudriere environment and it worked there.

Thanks for checking and correcting.