Bug 219929 - security/openssl: ${DIST_SUBDIR} not match in ${MASTER_SITE_BACKUP}
Summary: security/openssl: ${DIST_SUBDIR} not match in ${MASTER_SITE_BACKUP}
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Bernard Spil
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-11 16:29 UTC by Fukang Chen
Modified: 2017-07-24 17:52 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (brnrd)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fukang Chen freebsd_committer freebsd_triage 2017-06-11 16:29:11 UTC 
# cd /usr/ports/security/openssl/
# make -V MASTER_SITE_BACKUP
http://distcache.FreeBSD.org/ports-distfiles/openssl-1.0.2l/
# make -dV -V MASTER_SITE_BACKUP
http://distcache.FreeBSD.org/ports-distfiles/openssl-${DISTVERSIONPREFIX}1.0.2l${DISTVERSIONSUFFIX}/

It seems that ${DISTVERSIONFULL} was not expanded before assigning,
a workaround, maybe:

Index: Makefile
===================================================================
--- Makefile    (revision 442466)
+++ Makefile    (working copy)
@@ -7,7 +7,7 @@
 CATEGORIES=    security devel
 MASTER_SITES=  http://www.openssl.org/source/ \
                ftp://ftp.cert.dfn.de/pub/tools/net/openssl/source/
-DIST_SUBDIR=   ${DISTNAME:C/[a-z]$//}
+DIST_SUBDIR=   ${PORTNAME}-${DISTVERSION:C/[a-z]$//}

 MAINTAINER=    brnrd@FreeBSD.org
 COMMENT=       SSL and crypto library
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-07-24 17:51:37 UTC 
A commit references this bug:

Author: brnrd
Date: Mon Jul 24 17:51:16 UTC 2017
New revision: 446538
URL: https://svnweb.freebsd.org/changeset/ports/446538

Log:
  security/openssl: Fix MASTER_SITE_SUBDIR

   - DISTVERSIONFULL is not expanded before assignment

  PR:		219929
  Submitted by:	Fukang Chen <loader@FreeBSD.org>

Changes:
  head/security/openssl/Makefile
Comment 2 Bernard Spil freebsd_committer freebsd_triage 2017-07-24 17:52:26 UTC 
Thanks for reporting! Sorry it took too long to commit...