Bug 219944 - [patch] USE_GNOME= glib20:build doesn't work
Summary: [patch] USE_GNOME= glib20:build doesn't work
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-gnome mailing list
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-06-12 17:36 UTC by Harald Schmalzbauer
Modified: 2018-03-24 14:06 UTC (History)
3 users (show)

See Also:


Attachments
Add glib20_BUILD_DEPENDS definition. (527 bytes, patch)
2017-06-12 17:36 UTC, Harald Schmalzbauer
no flags Details | Diff
Add glib20_BUILD_DEPENDS definition. (447 bytes, patch)
2018-03-24 09:47 UTC, Harald Schmalzbauer
no flags Details | Diff
Add glib20_BUILD_DEPENDS definition. (448 bytes, patch)
2018-03-24 09:55 UTC, Harald Schmalzbauer
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Harald Schmalzbauer 2017-06-12 17:36:36 UTC
Created attachment 183437 [details]
Add glib20_BUILD_DEPENDS definition.

Trying to reduce superfluous dependencies, one might include STATIC option.
In that case, devel/glib20 might be needed during build only.

If you incorporate USE_GNOME and conditionally set it to glib20 or glib20:build, the latter would result in a build-depends-list (BUILD_DEPENDS) which is missing devel/glib20.

There's no check which prevents the usage of glib20:build, and adhoc I couldn't find a good reason for which it should be disallowed, but I'm not familar with USE_* and gnome at all.

The attached patch makes USE_GNOME=glib20:build working.

Something similar is needed probably for more components!
Comment 1 Harald Schmalzbauer 2018-03-24 09:46:24 UTC
Comment on attachment 183437 [details]
Add glib20_BUILD_DEPENDS definition.

This is no longer working, since comp_DETECT was removed in r457964.
I'll attach a updated version, which make USE GNOME=glib20:build work.
Comment 2 Harald Schmalzbauer 2018-03-24 09:47:47 UTC
Created attachment 191776 [details]
Add glib20_BUILD_DEPENDS definition.
Comment 3 Tobias C. Berner freebsd_committer 2018-03-24 09:49:41 UTC
Moin moin 

You're missing a $.

mfg Tobias
Comment 4 Harald Schmalzbauer 2018-03-24 09:55:49 UTC
Created attachment 191777 [details]
Add glib20_BUILD_DEPENDS definition.

Thanks, Tobias, sorry for the botchy post! New attachmant is corrected.
Comment 5 Antoine Brodin freebsd_committer 2018-03-24 09:58:50 UTC
We don't want to encourage static libs for security reasons,  so I think we should reject this patch.
Comment 6 Mathieu Arnold freebsd_committer 2018-03-24 14:06:27 UTC
I agree with antoine, the trend is to remove all the STATIC options.