I have a portbuild jail where I do not have gitlab_enable set and gitlab is trying to start even when gitlab_enable is not set.
I have added some debug prints to /usr/local/etc/rc.d/gitlab and it clearly show that gitlab_enable is not set (shows the default value NO).
root@portbuild:/usr/local/etc/rc.d # service gitlab start
Starting GitLab Unicorn
Starting GitLab Sidekiq
Could not find minitest-5.10.1 in any of the sources
Run `bundle install` to install missing gems.
..............................Waited 30s for the processes to write their pids, something probably went wrong.
yes, i can reproduce the bug. But the fix will cause a heavy rewriting of the service-file, which will take a while.
What about adding the following code:
# Do not start gitlab if not enabled in rc.conf.
case $gitlab_enable in
somewhere at the start of the file (e.g. right before # Read configuration variable file if it is present).
That is quite simple fix and it does not seem to break anything (it works for me).
Submit to new Maintainer. :)
I'm in CC if something needs to be committed.
Thanks for this. I already included it together with a security update.
Patch is on its way.
A commit references this bug:
Date: Tue Dec 12 10:54:13 UTC 2017
New revision: 456116
www/gitlab: Update from 10.1.4 to 10.1.5
- remove %%RUBY_SUFFIX%% from plist (thanks to swills)
- fix broken dependency to rubygem-pg in Gemfile
- fix broken dependency to rubygem-mysql2 in Gemfile
- Add support for reverse proxies in rc script
- Fix: gitlab starts even if gitlab_enable is not set
- Make default listenAddr configurable
PR: 224232 222896 220126 218388
Submitted by: swills, email@example.com, firstname.lastname@example.org, Mari?n ?ern? <email@example.com>
Reviewed by: tz
Approved by: maintainer
Differential Revision: https://reviews.freebsd.org/D12376