Bug 220171 - [PATCH] www/phpvirtualbox: update to support 5.1
Summary: [PATCH] www/phpvirtualbox: update to support 5.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Virtualbox Team (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-06-20 23:12 UTC by Ivan Rozhuk
Modified: 2017-07-27 15:27 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (vbox)


Attachments
disable annoying version alert message (636 bytes, patch)
2017-06-20 23:12 UTC, Ivan Rozhuk
no flags Details | Diff
with pull reqs (131.24 KB, patch)
2017-07-12 21:35 UTC, Ivan Rozhuk
no flags Details | Diff
without sparkweb (130.80 KB, patch)
2017-07-27 09:59 UTC, Ivan Rozhuk
no flags Details | Diff
without sparkweb2 (129.80 KB, patch)
2017-07-27 10:05 UTC, Ivan Rozhuk
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ivan Rozhuk 2017-06-20 23:12:11 UTC
Created attachment 183659 [details]
disable annoying version alert message

phpvirtualbox have no updated version, current version reports that it old and need to update on every page reload.
Patch disable annoying message.
Comment 1 Bernhard Froehlich freebsd_committer freebsd_triage 2017-06-21 09:49:05 UTC
Upstream is almost dead for this project but there are some contributors that have already added VirtualBox 5.1 support submitted as github pull request besides some other fixes.

https://github.com/phpvirtualbox/phpvirtualbox/pulls

I have not decided yet how to proceed with the phpvirtualbox port for FreeBSD since no better fork exists yet and other Linux distros seems to cherry pick from the pull requests currently. Maybe that is the best way short term and we should also do it the same way until either upstream sorts it out and does a release or some fork gains enough traction.

In either case I think just patching out the warning is not the right thing to do for the port.
Comment 2 Ivan Rozhuk 2017-07-12 21:35:08 UTC
Created attachment 184313 [details]
with pull reqs

latest commit +:

https://github.com/phpvirtualbox/phpvirtualbox/pull/22
Patch to support Virtualbox 5.1 #22

https://github.com/phpvirtualbox/phpvirtualbox/pull/24
Fix argument count mismatches revealed by PHP 7.1 #24

SF FR:#24 Allow usage of SparkGateway or Guacamole instead of Java vi… 
https://github.com/phpvirtualbox/phpvirtualbox/commit/2eefdbdfdb8c209799e26ab30f59321fda6d333c

https://github.com/phpvirtualbox/phpvirtualbox/pull/55
Make decryption of images/VMs work by not providing a password ID

https://github.com/phpvirtualbox/phpvirtualbox/pull/57
Tried to make clearOnSuspend work. #57

Bugs: wrong mem free/usage on VirtualBox host.
Comment 3 Ivan Rozhuk 2017-07-12 21:36:52 UTC
update to support 5.1
Comment 4 Ivan Rozhuk 2017-07-23 12:56:08 UTC
ping
Comment 5 Bernhard Froehlich freebsd_committer freebsd_triage 2017-07-24 07:15:39 UTC
The patch seems good to me except the SparkGateway stuff. I looked around a bit and the only notes and discussions that I could find about it is some random guy which attached it to the sourceforge ticket. Then someone picked that up and committed it to a testing branch on github. That really does not give me the feeling that it's ready yet.

Could you please exclude that sparkgateway stuff from your patch? The other stuff seems very good to me.
Comment 6 Ivan Rozhuk 2017-07-27 09:59:44 UTC
Created attachment 184759 [details]
without sparkweb
Comment 7 Ivan Rozhuk 2017-07-27 10:05:12 UTC
Created attachment 184760 [details]
without sparkweb2
Comment 8 commit-hook freebsd_committer freebsd_triage 2017-07-27 15:22:08 UTC
A commit references this bug:

Author: decke
Date: Thu Jul 27 15:21:32 UTC 2017
New revision: 446746
URL: https://svnweb.freebsd.org/changeset/ports/446746

Log:
  - Update to an unofficial 5.1-1 which supports VirtualBox 5.1

  Sadly upstream is very silent and has not released a new version
  which supports VirtualBox 5.1, supports PHP 7.1 or fixes bugs. In
  the meantime the community has created patches which are
  collected in the github projects bugtracker and pull requests.
  This unofficial version cherry picks the useful stuff of it.

  Highlights of unofficial phpvirtualbox 5.1-1:

  * based on git commit 65ebced (latest commit from May 19, 2016)

  * Patch to support Virtualbox 5.1
  https://github.com/phpvirtualbox/phpvirtualbox/pull/22

  * Fix argument count mismatches revealed by PHP 7.1
  https://github.com/phpvirtualbox/phpvirtualbox/pull/24

  * Make decryption of images/VMs work by not providing a password ID
  https://github.com/phpvirtualbox/phpvirtualbox/pull/55

  * Tried to make clearOnSuspend work
  https://github.com/phpvirtualbox/phpvirtualbox/pull/57

  PR:		ports/220171
  Submitted By:	rozhuk.im
  With hat:	vbox@ (kind of)

Changes:
  head/www/phpvirtualbox/Makefile
  head/www/phpvirtualbox/distinfo
  head/www/phpvirtualbox/files/
  head/www/phpvirtualbox/files/patch-endpoints_lib_config.php
  head/www/phpvirtualbox/files/patch-endpoints_lib_vboxServiceWrappers.php
  head/www/phpvirtualbox/files/patch-endpoints_lib_vboxconnector.php
  head/www/phpvirtualbox/files/patch-endpoints_lib_vboxweb-5.1.wsdl
  head/www/phpvirtualbox/files/patch-endpoints_lib_vboxwebService-5.1.wsdl
  head/www/phpvirtualbox/files/patch-panes_mediumEncryptionPasswords.html
  head/www/phpvirtualbox/pkg-plist
Comment 9 Bernhard Froehlich freebsd_committer freebsd_triage 2017-07-27 15:27:15 UTC
I have done some small changes and committed it. Thanks a lot for the
hard part of the work!

my changes:
* shortened the git revision
* moved USES above USE_PHP (to pet portlint)
* moved USE_GITHUB down (to pet portlint)
* fixed the patchfile names (vboxweb-5.1.wsdl vs vboxwebService-5.1.wsdl)
* regenerated the patches using "make makepatch"