Bug 220180 - sysutils/byobu: updato to 5.199 and takeover maintainership
Summary: sysutils/byobu: updato to 5.199 and takeover maintainership
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Richard Gallamore
URL: http://bazaar.launchpad.net/~kirkland...
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-21 10:20 UTC by Jov
Modified: 2017-06-29 19:10 UTC (History)
1 user (show)

See Also:


Attachments
byobu-5.119.diff (976 bytes, patch)
2017-06-21 10:20 UTC, Jov
no flags Details | Diff
byobu-5.119.diff (1.13 KB, patch)
2017-06-28 03:49 UTC, Jov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jov 2017-06-21 10:20:47 UTC
Created attachment 183670 [details]
byobu-5.119.diff

QA:
portlint -AC
WARN: Makefile: [32]: use ${VARIABLE}, instead of $(VARIABLE).
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
0 fatal errors and 2 warnings found.

poudriere testport passed on 11.0R-amd64
Comment 1 Richard Gallamore freebsd_committer freebsd_triage 2017-06-27 19:57:53 UTC
Hello Jov, thanks for taking another port and maintaining it. The following notice appears once the build is complete.

pkg-static: DEVELOPER_MODE: Notice: arch "FreeBSD:10:amd64" -- no architecture specific files found:
**** could this package use a wildcard architecture?pkg-static: DEVELOPER_MODE: Notice: arch "FreeBSD:10:amd64" -- no architecture specific files found:
**** could this package use a wildcard architecture?

Can you please add NO_ARCH=yes to satisfy this message?
Comment 2 Jov 2017-06-28 03:49:17 UTC
Created attachment 183869 [details]
byobu-5.119.diff

Add NO_ARCH=yes
Comment 3 Jov 2017-06-28 03:51:54 UTC
(In reply to Richard Gallamore from comment #1)
Wired, I build without this error.
Anyway, I added the NO_ARCH as there is not harm.
Comment 4 Richard Gallamore freebsd_committer freebsd_triage 2017-06-28 04:19:41 UTC
(In reply to Jov from comment #3)
Just noticed that these lines,
-e "s@/bin/bash@${LOCALBASE}/bin/bash@" \
-e "s@/usr/bin/python@${PYTHON_CMD}@"

Will the SHEBANGFIX not fix the target files?
Comment 5 Jov 2017-06-28 05:28:04 UTC
(In reply to Richard Gallamore from comment #4)
SHEBANG_FIX is not enough, shebang fix only take care of "#!/xxx...", byobu has more:

grep -R 'bin/bash' * | grep -v .bak
INSTALL:     CONFIG_SHELL=/bin/bash ./configure CONFIG_SHELL=/bin/bash
experimental/byobu-classroom:			useradd -m -s /usr/local/bin/bash -p "$cryptpw" "$GUESTUSER"
usr/lib/byobu/time_binary:#!/usr/local/bin/bash -e
usr/lib/byobu/include/mondrian:#!/usr/local/bin/bash
usr/lib/byobu/include/select-session.py:SHELL = os.getenv("SHELL", "/usr/local/bin/bash")
usr/bin/byobu-ulevel:#!/usr/local/bin/bash
usr/bin/byobu-disable-prompt:	if [ -n "$TMUX" ] && [ "$SHELL" = "/usr/local/bin/bash" ]; then
usr/bin/byobu-ugraph:#!/usr/local/bin/bash
usr/bin/byobu-ugraph.in:#!/usr/local/bin/bash
usr/bin/byobu-enable-prompt.in:[ "$SHELL" = "/usr/local/bin/bash" ] || exit 1
usr/bin/byobu-disable-prompt.in:	if [ -n "$TMUX" ] && [ "$SHELL" = "/usr/local/bin/bash" ]; then
usr/bin/byobu-ulevel.in:#!/usr/local/bin/bash
usr/bin/byobu-enable-prompt:[ "$SHELL" = "/usr/local/bin/bash" ] || exit 1
usr/share/byobu/profiles/tmux:# BUG: Should *not* hardcode /usr/local/bin/bash here
usr/share/byobu/tests/byobu-time-notifications.in:#!/usr/local/bin/bash
usr/share/byobu/tests/byobu-time-notifications:#!/usr/local/bin/bash
Comment 6 commit-hook freebsd_committer freebsd_triage 2017-06-29 18:14:30 UTC
A commit references this bug:

Author: ultima
Date: Thu Jun 29 18:14:07 UTC 2017
New revision: 444656
URL: https://svnweb.freebsd.org/changeset/ports/444656

Log:
  * Updated to 5.199
  * New maintainer Jov <amutu@amutu.com>
  * Added NO_ARCH

  Changelog:	http://bazaar.launchpad.net/~kirkland/byobu/trunk/view/head:/debian/changelog

  PR:		220180
  Submitted by:	Jov <amutu@amutu.com> (maintainer)
  Reviewed by:	lifanov (mentor)
  Approved by:	lifanov (mentor)
  Differential Revision:	https://reviews.freebsd.org/D11385

Changes:
  head/sysutils/byobu/Makefile
  head/sysutils/byobu/distinfo
Comment 7 Richard Gallamore freebsd_committer freebsd_triage 2017-06-29 19:10:29 UTC
Committed, thanks!