Bug 220214 - Try to handle man files for USE_PYTHON=concurrent
Summary: Try to handle man files for USE_PYTHON=concurrent
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-22 17:19 UTC by Fukang Chen
Modified: 2017-12-19 16:24 UTC (History)
4 users (show)

See Also:
antoine: exp-run+


Attachments
install man unique files (2.60 KB, text/plain)
2017-06-22 17:19 UTC, Fukang Chen
no flags Details
minor update (3.95 KB, text/plain)
2017-07-05 14:39 UTC, Fukang Chen
no flags Details
patch (4.07 KB, patch)
2017-12-11 13:02 UTC, Mathieu Arnold
no flags Details | Diff
v2 (6.38 KB, patch)
2017-12-14 17:31 UTC, Mathieu Arnold
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fukang Chen freebsd_committer 2017-06-22 17:19:57 UTC
Created attachment 183717 [details]
install man unique files

I'm not proposing this patch, just a thought.
Comment 1 Mathieu Arnold freebsd_committer 2017-07-03 15:07:58 UTC
I think locking it to man pages is a bad idea. It should be more generic, something along the lines of a *_WITH_SUFFIX variable or *_WITH_EXT or something.
Comment 2 Fukang Chen freebsd_committer 2017-07-05 14:39:50 UTC
Created attachment 184080 [details]
minor update

example:

UNIQUE_SUFFIX_TYPES+=  SUFFIX_MAN
UNIQUE_SUFFIX_MAN_FILES=       man/man1/command.1 man/man3/lib.3
UNIQUE_SUFFIX_MAN_WITH_EXT=         .[1-9]

they would be renamed to
man/man1/command${UNIQUE_SUFFIX}.1
man/man3/lib${UNIQUE_SUFFIX}.3
Comment 3 Mathieu Arnold freebsd_committer 2017-12-11 13:02:28 UTC
Created attachment 188715 [details]
patch
Comment 4 Antoine Brodin freebsd_committer 2017-12-14 16:19:37 UTC
I expect problems with at least 2 ports:

- mail/py-pymailq
- math/py-numpy

Can you provide patch for them?
Comment 5 Mathieu Arnold freebsd_committer 2017-12-14 16:57:36 UTC
Sure, testing.
Comment 6 Mathieu Arnold freebsd_committer 2017-12-14 17:31:39 UTC
Created attachment 188835 [details]
v2

fix those two ports.
Comment 7 Fukang Chen freebsd_committer 2017-12-15 10:45:34 UTC
Thanks mat@ and antoine@ :)
Comment 8 Antoine Brodin freebsd_committer 2017-12-17 06:56:51 UTC
Exp-run looks fine.
Comment 9 commit-hook freebsd_committer 2017-12-19 16:24:51 UTC
A commit references this bug:

Author: mat
Date: Tue Dec 19 16:23:49 UTC 2017
New revision: 456737
URL: https://svnweb.freebsd.org/changeset/ports/456737

Log:
  Enhance USES=uniquefiles to be more generic.

  This allows to have more complex renaming schemes.  Until now, it could
  only add a prefix or a suffix, but this was not working at all for man
  pages, because it would give man/man1/pyfoo.1.gz-2.7 or
  man/man1/pyfoo-1-2.7.gz.  With this change, a man page will be correctly
  renamed to man/man1/pyfoo-2.7.1.gz.

  Unfix ports that were already handling man pages.

  PR:		220214
  Submitted by:	Fukang Chen (previous patch)
  Exp-run by:	antoine
  Sponsored by:	Absolight
  Differential Revision:	https://reviews.freebsd.org/D13444

Changes:
  head/Mk/Uses/python.mk
  head/Mk/Uses/uniquefiles.mk
  head/mail/py-pymailq/Makefile
  head/math/py-numpy/Makefile
  head/math/py-numpy/pkg-plist
  head/www/py-ddgr/Makefile
  head/www/py-ddgr/files/patch-Makefile