Created attachment 183762 [details]
WARN: Makefile: for new port, make $FreeBSD$ tag in comment section empty, to make SVN happy.
0 fatal errors and 1 warning found.
poudriere testport pass on 11.0R-amd64
the upstream push the update(https://lists.freebsd.org/pipermail/freebsd-ports/2017-June/109211.html) on mail list and advice：
>According to , you are packaging libffcall for FreeBSD.
>I invite you to upgrade to version 1.13.
>With it, you can remove the BROKEN_* lines from .
>Also, you will no longer need patch-avcall_avcall-sparc64.S .
Hello Jov, can you please change the MASTER_SITES= to use the GNU group instead of hardcoding to only the one specified site. This will require MASTER_SITES_SUBDIR as well.
Actually, it would probably be best to change this portname to the more accurate, libffcall, then _SUBDIR and DISTNAME wouldn't be required at all.
Created attachment 183868 [details]
use GNU in MASTER_SITES
(In reply to Richard Gallamore from comment #1)
I just update the patch to use GNU Macros.
Yes, this port should be renamed to libffcall.But there are 4 ports depend on the port:
These ports should be changed at the same time.I think it is better to just update the port in this PR, and open a separate PR to make the rename&fix all these ports. Any idea?
(In reply to Jov from comment #3)
I agree, keep them separate. Make this an update and a follow up PR for moving the port with the updated DEPENDS. This should be best.
Created attachment 183945 [details]
A commit was made recently that rejects much of this patch. I updated the patch and added a couple fixed. Can you please look over it and approve if it looks good. Thanks.
Created attachment 183950 [details]
Fixed small mistake, hardcoded portname.
Comment on attachment 183950 [details]
A commit references this bug:
Date: Sat Jul 1 20:28:10 UTC 2017
New revision: 444836
* Updated to 1.13
* New maintainer Jov <firstname.lastname@example.org>
* License changed to GPLv2+
Submitted by: Jov <email@example.com> (maintainer)
Reviewed by: lifanov (mentor), matthew (mentor)
Approved by: matthew (mentor)
Differential Revision: https://reviews.freebsd.org/D11428
Committed, thanks! You can CC me for the libffcall move.