Bug 220274 - security/py-certbot: missing dependency on py-mock
Summary: security/py-certbot: missing dependency on py-mock
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Carlos J. Puga Medina
URL: https://reviews.freebsd.org/D10612
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2017-06-26 04:31 UTC by Randy Westlund
Modified: 2017-06-28 16:58 UTC (History)
1 user (show)

See Also:
koobs: maintainer-feedback+
cpm: maintainer-feedback+
koobs: merge-quarterly?


Attachments
patch (2.04 KB, patch)
2017-06-26 10:25 UTC, Carlos J. Puga Medina
koobs: maintainer-approval+
Details | Diff
patch (2.71 KB, patch)
2017-06-26 11:13 UTC, Carlos J. Puga Medina
cpm: maintainer-approval? (koobs)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Randy Westlund 2017-06-26 04:31:11 UTC
Using py27-certbot-0.15.0,1:

root@r2d2 /u/ports# certbot
Traceback (most recent call last):
  File "/usr/local/bin/certbot", line 6, in <module>
    from pkg_resources import load_entry_point
  File "/usr/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 3037, in <module>
    @_call_aside
  File "/usr/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 3021, in _call_aside
    f(*args, **kwargs)
  File "/usr/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 3050, in _initialize_master_working_set
    working_set = WorkingSet._build_master()
  File "/usr/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 655, in _build_master
    ws.require(__requires__)
  File "/usr/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 969, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/usr/local/lib/python2.7/site-packages/pkg_resources/__init__.py", line 855, in resolve
    raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'mock' distribution was not found and is required by certbot


Installing py27-mock resolves the issue.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2017-06-26 06:52:23 UTC
mock needs to be patched out of install_requires
Comment 2 Carlos J. Puga Medina freebsd_committer 2017-06-26 10:25:26 UTC
Created attachment 183803 [details]
patch

- Move py-mock requirement to dev_extras in setup.py
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2017-06-26 11:01:43 UTC
Comment on attachment 183803 [details]
patch

@Carlos I believe we need a PORTREVISION bump here.

Otherwise approved

Is the quarterly version affected? (mock listed in install_requires but not in RUN_DEPENDS?)
Comment 4 Carlos J. Puga Medina freebsd_committer 2017-06-26 11:13:19 UTC
Created attachment 183807 [details]
patch

- Bump PORTREVISION
Comment 5 Carlos J. Puga Medina freebsd_committer 2017-06-26 11:19:31 UTC
(In reply to Kubilay Kocak from comment #3)

MFH to 2017Q2 is required.

https://svnweb.freebsd.org/ports/branches/2017Q2/security/py-certbot/Makefile?revision=437407&view=markup#l31
Comment 6 commit-hook freebsd_committer 2017-06-26 11:57:22 UTC
A commit references this bug:

Author: cpm
Date: Mon Jun 26 11:56:17 UTC 2017
New revision: 444364
URL: https://svnweb.freebsd.org/changeset/ports/444364

Log:
  security/py-{acme,certbot}: fix missing dependency on py-mock

  Common:

  - Move py-mock requirement to dev_extras in setup.py
  - Bump PORTREVISION

  PR:		220274
  Submitted by:	cpm
  Reported by:	Randy Westlund <rwestlun@gmail.com>
  Approved by:	koobs (maintainer, py-certbot)
  MFH:		2017Q2

Changes:
  head/security/py-acme/Makefile
  head/security/py-acme/files/
  head/security/py-acme/files/patch-setup.py
  head/security/py-certbot/Makefile
  head/security/py-certbot/files/
  head/security/py-certbot/files/patch-setup.py
Comment 7 Kubilay Kocak freebsd_committer freebsd_triage 2017-06-26 13:11:55 UTC
(In reply to Carlos J. Puga Medina from comment #5)

mock is listed in RUN_DEPENDS (in 2016Q2)

 ${PYTHON_PKGNAMEPREFIX}mock>0:devel/py-mock

That means MFH is not required, or am i missing something?
Comment 8 Carlos J. Puga Medina freebsd_committer 2017-06-26 13:15:09 UTC
(In reply to Kubilay Kocak from comment #7)

I think it would be better to update to 0.15.0 on the quarterly branch.
Comment 9 commit-hook freebsd_committer 2017-06-28 16:56:50 UTC
A commit references this bug:

Author: cpm
Date: Wed Jun 28 16:56:17 UTC 2017
New revision: 444601
URL: https://svnweb.freebsd.org/changeset/ports/444601

Log:
  MFH: r444364

  security/py-{acme,certbot}: fix missing dependency on py-mock

  Common:

  - Move py-mock requirement to dev_extras in setup.py
  - Bump PORTREVISION

  PR:		220274
  Submitted by:	cpm
  Reported by:	Randy Westlund <rwestlun@gmail.com>
  Approved by:	koobs (maintainer, py-certbot)

  Approved by:	ports-secteam (miwi)

Changes:
_U  branches/2017Q2/
  branches/2017Q2/security/py-acme/Makefile
  branches/2017Q2/security/py-acme/files/
  branches/2017Q2/security/py-certbot/Makefile
  branches/2017Q2/security/py-certbot/files/
Comment 10 Carlos J. Puga Medina freebsd_committer 2017-06-28 16:58:47 UTC
Committed!

Thanks