Created attachment 183842 [details]
Allow users to have Emacs built with ImageMagick support even if they have another package that depends on 7.* version (e.g. multimedia/vapoursynth) which conflicts with 6.* (e.g. via bin/convert).
Comment on attachment 183842 [details]
Oops, somehow this regressed 6.* support.
Created attachment 183844 [details]
--without-imagemagick was passed more than once. New build logs:
I have yet to try it, although could you submit this image.c diff upstream, since it's better suited there ?
(In reply to Ashish SHUKLA from comment #3)
> could you submit this image.c diff upstream?
Both configure and image.c changes need proper conditionals before they can be used upstream. Dropping ImageMagick 6.* support would be a folly if the rest of the build system doesn't try to aggressively chase newest versions of dependencies. For one, ImageMagick 7.* isn't popular downstream yet: https://repology.org/metapackage/imagemagick/versions
This was committed (without discussion or approval) in r533098.
There are problems with conflicts, but since a new version of Emacs will soon be released, which will not depend on any ImageMagick (by default), perhaps it's best to just leave things as they are for now.
I should clarify that r245571 is a different approach, but still makes this 'overcome by events'. Please re-open if you disagree.