Bug 220306 - editors/emacs: add option for building against ImageMagick 7.*
Summary: editors/emacs: add option for building against ImageMagick 7.*
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: emacs@FreeBSD.org (Nobody)
Keywords: feature, patch
Depends on:
Reported: 2017-06-27 15:20 UTC by Jan Beich
Modified: 2020-05-02 20:47 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (ashish)

v0 (4.27 KB, patch)
2017-06-27 15:20 UTC, Jan Beich
no flags Details | Diff
v0.1 (4.84 KB, patch)
2017-06-27 15:40 UTC, Jan Beich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2017-06-27 15:20:15 UTC
Created attachment 183842 [details]

Allow users to have Emacs built with ImageMagick support even if they have another package that depends on 7.* version (e.g. multimedia/vapoursynth) which conflicts with 6.* (e.g. via bin/convert).

Build logs:
6.9: http://sprunge.us/jYZO
7.0: http://sprunge.us/JVYe
Comment 1 Jan Beich freebsd_committer 2017-06-27 15:26:05 UTC
Comment on attachment 183842 [details]

Oops, somehow this regressed 6.* support.
Comment 2 Jan Beich freebsd_committer 2017-06-27 15:40:51 UTC
Created attachment 183844 [details]

--without-imagemagick was passed more than once. New build logs:
6.9: http://sprunge.us/jQJZ
7.0: http://sprunge.us/HgKf
Comment 3 Ashish SHUKLA freebsd_committer 2017-07-16 02:29:32 UTC

I have yet to try it, although could you submit this image.c diff upstream, since it's better suited there ?

Comment 4 Jan Beich freebsd_committer 2017-07-17 01:37:08 UTC
(In reply to Ashish SHUKLA from comment #3)
> could you submit this image.c diff upstream?

Both configure and image.c changes need proper conditionals before they can be used upstream. Dropping ImageMagick 6.* support would be a folly if the rest of the build system doesn't try to aggressively chase newest versions of dependencies. For one, ImageMagick 7.* isn't popular downstream yet: https://repology.org/metapackage/imagemagick/versions
Comment 5 Joseph Mingrone freebsd_committer 2020-05-02 20:43:04 UTC
This was committed (without discussion or approval) in r533098.

There are problems with conflicts, but since a new version of Emacs will soon be released, which will not depend on any ImageMagick (by default), perhaps it's best to just leave things as they are for now.
Comment 6 Joseph Mingrone freebsd_committer 2020-05-02 20:47:11 UTC
I should clarify that r245571 is a different approach, but still makes this 'overcome by events'.  Please re-open if you disagree.