Bug 220340 - ports-mgmt/portlint: Doesn't complain when USE_x precedes USES
Summary: ports-mgmt/portlint: Doesn't complain when USE_x precedes USES
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Joe Marcus Clarke
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-28 17:23 UTC by Yuri Victorovich
Modified: 2017-07-30 20:58 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (marcus)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2017-06-28 17:23:08 UTC 
Section 13.1.7 here https://www.freebsd.org/doc/en/books/porters-handbook/porting-samplem.html#porting-samplem-order requires that USES precedes USE_x.

portlint allows USE_GITHUB before USES.
Comment 1 Joe Marcus Clarke freebsd_committer freebsd_triage 2017-07-22 01:53:14 UTC 
Added in 2.17.10.
Comment 2 Danilo G. Baio freebsd_committer freebsd_triage 2017-07-30 20:58:48 UTC 
Hi Marcus.

>WARN: Makefile: USE_* seen before USES.  According to the porters-handbook, USES must >appear first.
>0 fatal errors and 1 warning found.

I'm getting this warning in ports that not have USE_ in their Makefile.
Examples:

textproc/pdfgrep
textproc/pecl-yaml

Regards.