Bug 220356 - editors/libreoffice: properly handle verbose build
Summary: editors/libreoffice: properly handle verbose build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: office
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2017-06-29 12:45 UTC by Dmitry Marakasov
Modified: 2017-07-17 15:37 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (office)


Attachments
Patch (999 bytes, patch)
2017-06-29 12:45 UTC, Dmitry Marakasov
koobs: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer 2017-06-29 12:45:02 UTC
Created attachment 183909 [details]
Patch

Remove VERBOSE option, since verbose builds are mandatory as per PHB ยง12.10. Also fix handling verbose logs - --enable-verbose no longer works, use verbose=1 make environment variable instead.
Comment 1 Kubilay Kocak freebsd_committer 2017-06-29 12:55:07 UTC
@Dmitry I believe this comes under implicit (blanket) approval:

Approved by: portmgr (blanket)
Comment 2 Kubilay Kocak freebsd_committer 2017-06-29 12:55:21 UTC
Comment on attachment 183909 [details]
Patch

Approved by: portmgr (blanket)
Comment 3 Dmitry Marakasov freebsd_committer 2017-06-29 13:16:53 UTC
I've mentioned this multiple times before: I am quite aware of the blanket, and if I submit PR whith changes falling under it, I have clear intention of getting them reviewed.
Comment 4 commit-hook freebsd_committer 2017-07-17 15:37:26 UTC
A commit references this bug:

Author: amdmi3
Date: Mon Jul 17 15:36:34 UTC 2017
New revision: 446080
URL: https://svnweb.freebsd.org/changeset/ports/446080

Log:
  Fix verbose build (--enable-verbose no longer works) and enable it unconditionally as per PHB ?12.10.

  PR:		220356
  Approved by:	maintainer timeout (office, 2 weeks)

Changes:
  head/editors/libreoffice/Makefile