Bug 220403 - security/testssl.sh build failure on i386 FreeBSD 11.1Beta3
Summary: security/testssl.sh build failure on i386 FreeBSD 11.1Beta3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Tobias Kortkamp
URL: https://reviews.freebsd.org/D11436
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-01 00:02 UTC by dewayne
Modified: 2017-07-06 05:35 UTC (History)
0 users

See Also:
tobik: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description dewayne 2017-07-01 00:02:54 UTC
Build result on i386 FreeBSD 11.1 Beta3 using security/openssl

/usr/local/libexec/ccache/cc -I.. -I../.. -I../modes -I../asn1 -I../evp -I../../include  -DZLIB -DOPENSSL_THREADS -pthread -D_THREAD_SAFE -D_REENTRANT -DDSO_DLFCN -DHAVE_DLFCN_H -DOPENSSL_USE_IPV6 -DL_ENDIAN -O3 -fomit-frame-pointer -Wall -DOPENSSL_EXPERIMENTAL_JPAKE -DOPENSSL_BN_ASM_PART_WORDS -DOPENSSL_BN_ASM_MONT -DOPENSSL_BN_ASM_GF2m -DSHA1_ASM -DSHA256_ASM -DSHA512_ASM -DMD5_ASM -DRMD160_ASM -DAES_ASM -DGHASH_ASM -c ecp_nistp224.c -o ecp_nistp224.o
ecp_nistp224.c:43:9: error: unknown type name '__uint128_t'
typedef __uint128_t uint128_t;  /* nonstandard; implemented by gcc on 64-bit
        ^
ecp_nistp224.c:460:33: warning: overflow in expression; result is -2147483648 with type 'int' [-Winteger-overflow]
        (((widelimb) 1) << 104) - (((widelimb) 1) << 64);
                                ^
ecp_nistp224.c:456:51: warning: shift count >= width of type [-Wshift-count-overflow]
    static const widelimb two120 = ((widelimb) 1) << 120;
                                                  ^  ~~~
ecp_nistp224.c:457:55: warning: shift count >= width of type [-Wshift-count-overflow]
    static const widelimb two120m64 = (((widelimb) 1) << 120) -
                                                      ^  ~~~

Suggestion: Probably should restrict the arch that it can be built for.


As informational.  Build completes successfully on amd64 FreeBSD 11.1 Beta3 using security/libressl with the following messages:
       
cc: warning: argument unused during compilation: '-pthread' [-Wunused-command-line-argument]
cc: warning: argument unused during compilation: '-D ZLIB' [-Wunused-command-line-argument]
cc: warning: argument unused during compilation: '-D OPENSSL_THREADS' [-Wunused-command-line-argument]
cc: warning: argument unused during compilation: '-D _THREAD_SAFE' [-Wunused-command-line-argument]
cc: warning: argument unused during compilation: '-D _REENTRANT' [-Wunused-command-line-argument]
cc: warning: argument unused during compilation: '-D DSO_DLFCN' [-Wunused-command-line-argument]
cc: warning: argument unused during compilation: '-D HAVE_DLFCN_H' [-Wunused-command-line-argument]
cc: warning: argument unused during compilation: '-D OPENSSL_USE_IPV6' [-Wunused-command-line-argument]
cc: warning: argument unused during compilation: '-D L_ENDIAN' [-Wunused-command-line-argument]
cc: warning: argument unused during compilation: '-D OPENSSL_EXPERIMENTAL_JPAKE' [-Wunused-command-line-argument]
cc: warning: argument unused during compilation: '-D OPENSSL_IA32_SSE2' [-Wunused-command-line-argument]
cc: warning: argument unused during compilation: '-D OPENSSL_BN_ASM_MONT' [-Wunused-command-line-argument]
cc: warning: argument unused during compilation: '-D OPENSSL_BN_ASM_MONT5' [-Wunused-command-line-argument]
cc: warning: argument unused during compilation: '-D OPENSSL_BN_ASM_GF2m' [-Wunused-command-line-argument]
cc: warning: argument unused during compilation: '-D SHA1_ASM' [-Wunused-command-line-argument]
cc: warning: argument unused during compilation: '-D SHA256_ASM' [-Wunused-command-line-argument]
cc: warning: argument unused during compilation: '-D SHA512_ASM' [-Wunused-command-line-argument]
cc: warning: argument unused during compilation: '-D MD5_ASM' [-Wunused-command-line-argument]
cc: warning: argument unused during compilation: '-D AES_ASM' [-Wunused-command-line-argument]
cc: warning: argument unused during compilation: '-D VPAES_ASM' [-Wunused-command-line-argument]
cc: warning: argument unused during compilation: '-D BSAES_ASM' [-Wunused-command-line-argument]
cc: warning: argument unused during compilation: '-D WHIRLPOOL_ASM' [-Wunused-command-line-argument]
cc: warning: argument unused during compilation: '-D GHASH_ASM' [-Wunused-command-line-argument]
cc: warning: argument unused during compilation: '-D ECP_NISTZ256_ASM' [-Wunused-command-line-argument]
Comment 1 Tobias Kortkamp freebsd_committer freebsd_triage 2017-07-01 04:32:59 UTC
Thanks, there is a patch here https://reviews.freebsd.org/D11436.diff
which builds fine on 10.3/i386 and 11.0/i386.  Can you test on 11.1-BETA3?
Comment 2 dewayne 2017-07-01 18:22:27 UTC
(In reply to Tobias Kortkamp from comment #1)
Thanks Tobias, the patch enables the build on i386 FreeBSD 11.1Beta3. (& amd64 with libressl)
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-07-05 07:54:26 UTC
A commit references this bug:

Author: tobik
Date: Wed Jul  5 07:53:45 UTC 2017
New revision: 445053
URL: https://svnweb.freebsd.org/changeset/ports/445053

Log:
  Only use enable-ec_nistp_64_gcc_128 on amd64 since it requires a
  64-bit little-endian architecture and fix the build on !amd64

  ecp_nistp224.c:43:9: error: unknown type name '__uint128_t'
  typedef __uint128_t uint128_t;	/* nonstandard; implemented by gcc on 64-bit
  	^

  PR:		220403
  Reported by:	dewayne@heuristicsystems.com.au
  Approved by:	mat (mentor)
  Differential Revision:	https://reviews.freebsd.org/D11436
  MFH:		2017Q3

Changes:
  head/security/testssl.sh/Makefile
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-07-06 05:34:38 UTC
A commit references this bug:

Author: tobik
Date: Thu Jul  6 05:34:14 UTC 2017
New revision: 445128
URL: https://svnweb.freebsd.org/changeset/ports/445128

Log:
  MFH: r445053

  Only use enable-ec_nistp_64_gcc_128 on amd64 since it requires a
  64-bit little-endian architecture and fix the build on !amd64

  ecp_nistp224.c:43:9: error: unknown type name '__uint128_t'
  typedef __uint128_t uint128_t;	/* nonstandard; implemented by gcc on 64-bit
  	^

  PR:		220403
  Reported by:	dewayne@heuristicsystems.com.au
  Approved by:	mat (mentor)
  Differential Revision:	https://reviews.freebsd.org/D11436

  Approved by:	ports-secteam (blanket)

Changes:
_U  branches/2017Q3/
  branches/2017Q3/security/testssl.sh/Makefile