Bug 220470 - mail/postfix-policyd-spf-python: 1.3.2 has some issues with Python 3.6
Summary: mail/postfix-policyd-spf-python: 1.3.2 has some issues with Python 3.6
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kubilay Kocak
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-04 18:25 UTC by Kamigishi Rei
Modified: 2018-05-15 05:05 UTC (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kamigishi Rei 2017-07-04 18:25:18 UTC 
When used with Python 3.6, 1.3.2 exits with status 120 (which has a special meaning starting with that Python version) with almost each incoming SMTP connexion:

Jul  5 02:29:02 tricoro postfix/spawn[39190]: warning: command /usr/local/bin/policyd-spf exit status 120

There is also version 2.0.1 available for quite a while, are there any plans to update the port?
Comment 1 Danilo G. Baio freebsd_committer freebsd_triage 2017-07-05 00:43:56 UTC 
Hi Kamigishi.

Thank you for this.

I've saw that you already reported this upstream, this is great.
https://bugs.launchpad.net/pypolicyd-spf/+bug/1702343

What about this?

Keep this port and create a new one, because the version 2.0.1 is not compatible with Python2.

> --- 2.0.0 (2016-12-02)
>   ! No longer python2 compatible, minimum python3 version is 3.3 for ipaddress

And also rename this port.

mail/postfix-policyd-spf-python  -> mail/py-pypolicyd-spf-1 (v1.3.2 python:2.7+)
repocopy mail/py-pypolicyd-spf-1 -> mail/py-pypolicyd-spf   (v2.0.1 python:3.3+)

https://wiki.freebsd.org/Python/PortsPolicy

CCing python@
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2017-07-14 08:56:14 UTC 
@Danilo If the 1.x series is not longer supported or its not a separately and concurrently maintained python 2/3 compatible branch, then the port should be upgraded through to the next major versions (2.x).

Also, any rename should be committed separately as it comprises its own logically separate change. Rename should also be separate (from any fix/fixes) so that any fixes can be merged (to quarterly) too.
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2017-07-14 09:02:28 UTC 
Update is being handled in bug 220706, remove that (version update) from this issues scope.

Have it block (temporarily) 220706 so any identified bug fix can be merged. The update should not wait forever though.
Comment 4 Danilo G. Baio freebsd_committer freebsd_triage 2017-07-15 14:08:51 UTC 
(In reply to Kubilay Kocak from comment #2)

Hi koobs.

I was thinking in keep the old version for a while because this port wont be built in the FreeBSD cluster in this moment if it is updated to v2.0.1 python:3.3+.

Forgetting about the renaming part, it would be like these:

mail/postfix-policyd-spf-python  -> mail/postfix-policyd-spf-python-1 (v1.3.2 python:2.7+)
Expiry date for 6 months ? Wait for flavors ?

mail/postfix-policyd-spf-python: Update to v2.0.1 python:3.3+
UPDATING notes

What do you think?

Regards.
Comment 5 Yasuhiro Kimura freebsd_committer freebsd_triage 2018-01-27 18:28:37 UTC 
Since ports r459884 updated mail/postfix-policyd-spf-python to 2.0.2, should this bug report be closed with "Overcome By Events"?
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2018-05-15 05:05:23 UTC 
Closing Overcome By Events, as the port has been updated to 2.x (bug 220706)

If the reported issue remains, please re-open this issue with a change proposal