Bug 220528 - [new port] databases/sqlite-src: alternative port of SQLite
Summary: [new port] databases/sqlite-src: alternative port of SQLite
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-ports-bugs mailing list
URL:
Keywords:
Depends on:
Blocks: 221735
  Show dependency treegraph
 
Reported: 2017-07-07 07:26 UTC by Pavel Volkov
Modified: 2018-08-29 11:59 UTC (History)
3 users (show)

See Also:


Attachments
patch for create new port (14.33 KB, patch)
2017-07-07 07:26 UTC, Pavel Volkov
no flags Details | Diff
poudriere log (58.37 KB, text/plain)
2017-07-07 07:27 UTC, Pavel Volkov
no flags Details
[new] patch for create new port (15.46 KB, patch)
2017-08-27 10:18 UTC, Pavel Volkov
no flags Details | Diff
poudriere log (59.17 KB, text/plain)
2017-08-27 10:19 UTC, Pavel Volkov
no flags Details
[new] patch for create port with SQLite version 3.21 (16.08 KB, patch)
2017-12-16 13:39 UTC, Pavel Volkov
no flags Details | Diff
poudriere log (80.70 KB, text/plain)
2017-12-16 13:40 UTC, Pavel Volkov
no flags Details
[new] patch for create port with SQLite version 3.24 (17.57 KB, patch)
2018-08-29 11:35 UTC, Pavel Volkov
no flags Details | Diff
build log (40.23 KB, text/plain)
2018-08-29 11:36 UTC, Pavel Volkov
no flags Details
portlint log (41.57 KB, text/plain)
2018-08-29 11:37 UTC, Pavel Volkov
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Volkov 2017-07-07 07:26:06 UTC
Created attachment 184143 [details]
patch for create new port

Hello.
This is an alternative port of SQLite based on the creation of the source code.
This allows you to use more compilation options, extension modules and test the created libraries.
This solves the problem with PR#207383.
I hope in the future this port will be used instead of existing databases/sqlite3 and databases/tcl-sqlite3.
Comment 1 Pavel Volkov 2017-07-07 07:27:26 UTC
Created attachment 184144 [details]
poudriere log
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2017-07-07 07:32:59 UTC
Fix Synopsis.

It is not necessary to set the maintainer-approval flag for a new port.  This is intended for the reply of an existing maintainer of an existing port.
Comment 3 Pavel Volkov 2017-07-07 07:37:02 UTC
(In reply to Mark Linimon from comment #2)
I'm sorry. I will take into account in the future. Thanks.
Comment 4 Pavel Volkov 2017-08-27 10:18:24 UTC
Created attachment 185807 [details]
[new] patch for create new port

New patch for new, SQLite 3.20.1 version.
Comment 5 Pavel Volkov 2017-08-27 10:19:04 UTC
Created attachment 185808 [details]
poudriere log
Comment 6 Pavel Volkov 2017-12-16 13:39:54 UTC
Created attachment 188878 [details]
[new] patch for create port with SQLite version 3.21
Comment 7 Pavel Volkov 2017-12-16 13:40:30 UTC
Created attachment 188879 [details]
poudriere log
Comment 8 Nathan 2018-08-28 03:13:19 UTC
There is newer version out, if you still plan to get this in ports
Comment 9 Pavel Volkov 2018-08-29 11:35:37 UTC
Created attachment 196673 [details]
[new] patch for create port with SQLite version 3.24
Comment 10 Pavel Volkov 2018-08-29 11:36:35 UTC
Created attachment 196674 [details]
build log
Comment 11 Pavel Volkov 2018-08-29 11:37:06 UTC
Created attachment 196675 [details]
portlint log
Comment 12 Nathan 2018-08-29 11:45:10 UTC
Don’t leave comments that doesn’t atleast explain something like:
 #  Length         |     |                          Length                |                                                                               OPTIONS_SUB=            yes                        
OPTIONS_DEFAULT=        # Clean default options                                                       # ===> OPTIONS_DEFINE                           
#OPTIONS_DEFINE=        # portlint, for what?

Combine options_define for example:

OPTIONS_DEFINE=  EXTENSIONS JSON
Don’t need += in options_define if you just do it together 

Makes the makefile cleaner and easier to read
Comment 13 Nathan 2018-08-29 11:45:56 UTC
(In reply to Nathan from comment #12)
Leave in options_sub=yes
Comment 14 Nathan 2018-08-29 11:53:24 UTC
JSON1_CONFIGURE_ON=     --enable-json1

Change switches that use —-enable to be like 
JSON1_CONFIGURE_ENABLE=  json
As an example
It’s safer to make sure enable/disable works

On switches usually need an off switch to make sure things are enabled or disabled. 

Also combine the defining of options to one line:
OPTIONS_DEFINE= EXAMPLES JSON1 ANOTHER MORE ETC
Comment 15 Nathan 2018-08-29 11:59:31 UTC
Also remove unneeded comments like #DEFINE_OPTIONS= portlint for what 

#length