Bug 220595 - japanese/nethack34: Fix the BROKEN_FreeBSD_12 flag, Take MAINTAINER'ship
Summary: japanese/nethack34: Fix the BROKEN_FreeBSD_12 flag, Take MAINTAINER'ship
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs mailing list
URL:
Keywords: easy, patch
Depends on:
Blocks:
 
Reported: 2017-07-10 09:22 UTC by WATANABE Kazuhiro
Modified: 2017-08-18 17:32 UTC (History)
0 users

See Also:
koobs: merge-quarterly?


Attachments
An svn diff for japanese/nethack34 (1.06 KB, patch)
2017-07-10 09:22 UTC, WATANABE Kazuhiro
koobs: maintainer-approval+
Details | Diff
poudriere testport log on 12.0-CURRENT without the patch (14.72 KB, text/plain)
2017-07-10 09:24 UTC, WATANABE Kazuhiro
no flags Details
poudriere testport log on 12.0-CURRENT with the patch (gzipped) (355.76 KB, application/gzip)
2017-07-10 09:27 UTC, WATANABE Kazuhiro
no flags Details
poudriere testport log on 12.0-CURRENT with the patch (gzipped) (355.76 KB, application/octet-stream)
2017-07-10 09:33 UTC, WATANABE Kazuhiro
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description WATANABE Kazuhiro 2017-07-10 09:22:08 UTC
Created attachment 184220 [details]
An svn diff for japanese/nethack34

(1) japanese/nethack34 fails to build on 12-current due to a different
    function prototype for 'srandom'.
    To fix the problem, include stdlib.h instead of the function prototype.

    This patch is taken from games/nethack34.  Thanks!

(2) Take maintainership.
Comment 1 WATANABE Kazuhiro 2017-07-10 09:24:12 UTC
Created attachment 184221 [details]
poudriere testport log on 12.0-CURRENT without the patch
Comment 2 WATANABE Kazuhiro 2017-07-10 09:27:59 UTC
Created attachment 184222 [details]
poudriere testport log on 12.0-CURRENT with the patch (gzipped)
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2017-07-10 09:32:51 UTC
Comment on attachment 184220 [details]
An svn diff for japanese/nethack34

Port is unmaintained, implicit approval
Comment 4 WATANABE Kazuhiro 2017-07-10 09:33:23 UTC
Created attachment 184223 [details]
poudriere testport log on 12.0-CURRENT with the patch (gzipped)
Comment 5 Steve Wills freebsd_committer 2017-08-18 17:20:11 UTC
Attachment 184220 [details] applies cleanly for me.
Comment 6 commit-hook freebsd_committer 2017-08-18 17:31:29 UTC
A commit references this bug:

Author: swills
Date: Fri Aug 18 17:30:56 UTC 2017
New revision: 448262
URL: https://svnweb.freebsd.org/changeset/ports/448262

Log:
  japanese/nethack34: Fix the BROKEN_FreeBSD_12 flag

  Pass maintainership to submitter

  PR:		220595
  Submitted by:	WATANABE Kazuhiro <CQG00620@nifty.ne.jp>

Changes:
  head/japanese/nethack34/Makefile
  head/japanese/nethack34/files/patch-include-system.h
Comment 7 Steve Wills freebsd_committer 2017-08-18 17:32:08 UTC
Committed, thanks!