Bug 220603 - multimedia/kodi: update to 17.3
Summary: multimedia/kodi: update to 17.3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Carlos J. Puga Medina
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2017-07-10 14:28 UTC by Mikael Urankar
Modified: 2017-08-08 18:30 UTC (History)
2 users (show)

See Also:
mickael.maillot: maintainer-feedback+
cpm: merge-quarterly+


Attachments
patch (1.10 KB, patch)
2017-07-10 14:28 UTC, Mikael Urankar
no flags Details | Diff
patch (2.26 KB, patch)
2017-08-05 09:32 UTC, Mikael Urankar
cpm: maintainer-approval? (mickael.maillot)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikael Urankar freebsd_committer freebsd_triage 2017-07-10 14:28:45 UTC
Created attachment 184233 [details]
patch

testport OK

thanks in advance.
Comment 1 Carlos J. Puga Medina freebsd_committer freebsd_triage 2017-07-10 14:41:17 UTC
(In reply to mikael.urankar from comment #0)

Take :)
Comment 2 Carlos J. Puga Medina freebsd_committer freebsd_triage 2017-07-10 14:45:29 UTC
I think that we should unregister

CONFLICTS_BUILD=compat9x

since it was fixed in r440033

https://svnweb.freebsd.org/ports?view=revision&revision=440033

Do you agree?
Comment 3 Mikael Urankar freebsd_committer freebsd_triage 2017-07-10 18:19:03 UTC
I don't know why CONFLICTS_BUILD was added, if you think it can be removed just do it :)
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-07-11 09:54:34 UTC
A commit references this bug:

Author: cpm
Date: Tue Jul 11 09:53:40 UTC 2017
New revision: 445487
URL: https://svnweb.freebsd.org/changeset/ports/445487

Log:
  multimedia/kodi: update to 17.3 (bugfix)

  - Update kodi to 1.7.3
  - Unregister CONFLICTS_BUILD because it was fixed in r440033

  Changes: https://kodi.tv/article/kodi-v173-minor-bug-fix-and-security-release

  PR:		220603
  Submitted by:	Mikael Urankar <mikael.urankar@gmail.com> (maintainer)
  MFH:		2017Q3

Changes:
  head/multimedia/kodi/Makefile
  head/multimedia/kodi/distinfo
Comment 5 Mikael Urankar freebsd_committer freebsd_triage 2017-07-11 09:59:18 UTC
I'm not the maintainer :)
thanks anyway :)
Comment 6 Carlos J. Puga Medina freebsd_committer freebsd_triage 2017-07-11 10:05:08 UTC
(In reply to mikael.urankar from comment #5)

You are right! The current maintainer has not given any signals for a long time.

Are you interested in maintaining this port?
Comment 7 commit-hook freebsd_committer freebsd_triage 2017-07-12 02:41:12 UTC
A commit references this bug:

Author: cpm
Date: Wed Jul 12 02:40:39 UTC 2017
New revision: 445566
URL: https://svnweb.freebsd.org/changeset/ports/445566

Log:
  MFH: r445487

  multimedia/kodi: update to 17.3 (bugfix)

  - Update kodi to 1.7.3
  - Unregister CONFLICTS_BUILD because it was fixed in r440033

  Changes: https://kodi.tv/article/kodi-v173-minor-bug-fix-and-security-release

  PR:		220603
  Submitted by:	Mikael Urankar <mikael.urankar@gmail.com> (maintainer)

  Approved by:	ports-secteam (junovitch)

Changes:
_U  branches/2017Q3/
  branches/2017Q3/multimedia/kodi/Makefile
  branches/2017Q3/multimedia/kodi/distinfo
Comment 8 Carlos J. Puga Medina freebsd_committer freebsd_triage 2017-07-12 02:42:43 UTC
Committed!

Thanks
Comment 9 mickael.maillot 2017-08-04 19:21:56 UTC
nice placebo update ! you kept the same sha1 commit lol

In the Makefile
xbmc:xbmc:fc1619b needs to be updated to xbmc:xbmc:147cec4
Comment 10 Mikael Urankar freebsd_committer freebsd_triage 2017-08-05 09:32:20 UTC
Created attachment 185040 [details]
patch

damn, you're right.
How about the attached patch, putting the sha at the top of the makefile should ease upgrade? but portlint complains :(

WARN: Makefile: "LIB_DEPENDS" has to appear earlier.
WARN: Makefile: "BUILD_DEPENDS" has to appear earlier.
WARN: Makefile: "RUN_DEPENDS" has to appear earlier.
Comment 11 Mikael Urankar freebsd_committer freebsd_triage 2017-08-05 15:26:48 UTC
reopening
Comment 12 Carlos J. Puga Medina freebsd_committer freebsd_triage 2017-08-07 18:54:04 UTC
Comment on attachment 185040 [details]
patch

@Mickael

Please, set (+) to approve the new attachment.

Thanks for pointing out the mistake.
Comment 13 commit-hook freebsd_committer freebsd_triage 2017-08-08 18:24:31 UTC
A commit references this bug:

Author: cpm
Date: Tue Aug  8 18:23:30 UTC 2017
New revision: 447558
URL: https://svnweb.freebsd.org/changeset/ports/447558

Log:
  - Really update kodi to 17.3
  - Sort Makefile to make portlint happy
  - Bump PORTREVISION

  PR:		220603
  Submitted by:	Mikael Urankar <mikael.urankar@gmail.com>
  Approved by:	Mickael Maillot <mickael.maillot@gmail.com> (maintainer)
  MFH:		2017Q3 (blanket)

Changes:
  head/multimedia/kodi/Makefile
  head/multimedia/kodi/distinfo
Comment 14 commit-hook freebsd_committer freebsd_triage 2017-08-08 18:29:37 UTC
A commit references this bug:

Author: cpm
Date: Tue Aug  8 18:28:57 UTC 2017
New revision: 447560
URL: https://svnweb.freebsd.org/changeset/ports/447560

Log:
  MFH: r447558

  - Really update kodi to 17.3
  - Sort Makefile to make portlint happy
  - Bump PORTREVISION

  PR:		220603
  Submitted by:	Mikael Urankar <mikael.urankar@gmail.com>
  Approved by:	Mickael Maillot <mickael.maillot@gmail.com> (maintainer)

  Approved by:	ports-secteam (blanket)

Changes:
_U  branches/2017Q3/
  branches/2017Q3/multimedia/kodi/Makefile
  branches/2017Q3/multimedia/kodi/distinfo
Comment 15 Carlos J. Puga Medina freebsd_committer freebsd_triage 2017-08-08 18:30:57 UTC
Committed, thank you both!