Bug 220648 - java/icedtea-web: Remove libxul dependency
Summary: java/icedtea-web: Remove libxul dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Jung-uk Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-11 17:35 UTC by Andrew Marks
Modified: 2017-07-12 05:47 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (java)


Attachments
removed gecko from PLUGIN_USES (404 bytes, patch)
2017-07-11 17:35 UTC, Andrew Marks
no flags Details | Diff
Fix runtime dependency (939 bytes, patch)
2017-07-11 19:27 UTC, Jung-uk Kim
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Marks 2017-07-11 17:35:21 UTC
Created attachment 184268 [details]
removed gecko from PLUGIN_USES

Just rebuilt java/icedtea-web with the attached patch and it seems to be working fine. I am far from knowing all that gecko provides, but I removed gecko from PLUGIN_USES in the Makefile just to get rid of the libxul dependency.

libxul has been archived by Mozilla, currently has multiple vulnerabilities, and cannot be updated on FreeBSD:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220607

My method of removing it as a dependency may not be correct.
Comment 1 Jung-uk Kim freebsd_committer 2017-07-11 17:59:59 UTC
Since Firefox 52, NPAPI is no longer supported:

https://support.mozilla.org/en-US/kb/npapi-plugins

How did you "test" your IcedTea plugin?
Comment 2 Tim Z 2017-07-11 18:07:18 UTC
NPAPI plugins still work on Firefox 52 ESR branch.
Comment 3 Jung-uk Kim freebsd_committer 2017-07-11 18:12:02 UTC
(In reply to Tim Z from comment #2)
Yes, I just realized that.  Did you test it with www/firefox-esr?
Comment 4 Andrew Marks 2017-07-11 18:21:15 UTC
sorry, I should have mentioned I am using:

firefox-esr-52.2.1,1

from the FreeBSD pkg repo

I certainly did not test it, but it appears to still be working here (first test not second test):

http://www-pw.physics.uiowa.edu/das2/javaPlatformTest.jbf.html

which I found via googling "java web start test" and also an internal corporate site that I cannot disclose and would not be very useful even if I did.

I do not claim to know what in libxul icedtea-web requires or what an actual good test would be.
Comment 5 Jung-uk Kim freebsd_committer 2017-07-11 18:34:32 UTC
(In reply to Andrew Marks from comment #4)
Probably the configure script picked up header files from Firefox.  I'll take a look.
Comment 6 Jung-uk Kim freebsd_committer 2017-07-11 18:34:49 UTC
I'll take it.
Comment 7 Tim Z 2017-07-11 18:39:22 UTC
With firefox-esr-52.2.0,1 & icedtea-web-1.6.2_2 & libxul-45.9.0_1 (i.e. WITHOUT the patch) the http://www-pw.physics.uiowa.edu/das2/javaPlatformTest.jbf.html page works fully (test 1 & test 2) once I allow the page to run the plugin.
Comment 8 Jung-uk Kim freebsd_committer 2017-07-11 19:22:39 UTC
www/libxul is required for build because header files are required for NPAPI plugin.  Unfortunately, www/firefox-esr does not include required header files.  Therefore, we have no choice but to include www/libxul to build dependency when PLUGIN option is enabled.  However, USES=gecko here is wrong because it assumes runtime dependency.  I'll replace "PLUGIN_USES=gecko ..." with "PLUGIN_BUILD_DEPENDS=...:www/libxul".
Comment 9 Jung-uk Kim freebsd_committer 2017-07-11 19:27:37 UTC
Created attachment 184284 [details]
Fix runtime dependency
Comment 10 commit-hook freebsd_committer 2017-07-11 19:44:32 UTC
A commit references this bug:

Author: jkim
Date: Tue Jul 11 19:44:10 UTC 2017
New revision: 445546
URL: https://svnweb.freebsd.org/changeset/ports/445546

Log:
  Remove an unnecessary runtime dependency for NPAPI plugin support.

  PR:		220648
  MFH:		2017Q3

Changes:
  head/java/icedtea-web/Makefile
Comment 11 commit-hook freebsd_committer 2017-07-12 05:47:36 UTC
A commit references this bug:

Author: jkim
Date: Wed Jul 12 05:46:47 UTC 2017
New revision: 445573
URL: https://svnweb.freebsd.org/changeset/ports/445573

Log:
  MFH:	r445546

  Remove an unnecessary runtime dependency for NPAPI plugin support.

  PR:		220648
  Approved by:	ports-secteam (junovitch)

Changes:
_U  branches/2017Q3/
  branches/2017Q3/java/icedtea-web/Makefile