Bug 220710 - ctladm manpage incorrect
Summary: ctladm manpage incorrect
Status: Closed FIXED
Alias: None
Product: Documentation
Classification: Unclassified
Component: Books & Articles (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-doc (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-13 16:29 UTC by sseekamp
Modified: 2017-07-22 10:18 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description sseekamp 2017-07-13 16:29:22 UTC
The ctladm man page incorrectly duplicates content which is confusing. Under the "modify" subcommand it lists the same options as the "remove" subcommand:

modify       Modify a LUN size.  The backend, the LUN number, and the
                  size must be specified.

                  -l lun_id       Specify the LUN number to remove.


remove       Remove a LUN.  The backend must be specified, and the LUN
                  number must also be specified.  Backend-specific options may
                  also be specified with the -o flag.

                  -l lun_id       Specify the LUN number to remove.
Comment 1 Benedict Reuschling freebsd_committer freebsd_triage 2017-07-15 15:01:38 UTC
I opened a review for this bug here:
https://reviews.freebsd.org/D11608
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-07-15 17:59:38 UTC
A commit references this bug:

Author: bcr
Date: Sat Jul 15 17:59:28 UTC 2017
New revision: 321023
URL: https://svnweb.freebsd.org/changeset/base/321023

Log:
  The ctladm man page incorrectly duplicated the text for the
  delete subcommand in the modify section. Rewrite the
  modify description text in two places to say modify/modified
  instead of remove/removed.

  PR:		220710
  Submitted by:	sseekamp@risei.net
  Reviewed by:	mav@
  MFC after:	1 week
  Differential Revision:	https://reviews.freebsd.org/D11608

Changes:
  head/usr.sbin/ctladm/ctladm.8
Comment 3 Benedict Reuschling freebsd_committer freebsd_triage 2017-07-15 18:01:37 UTC
A commit was made to FreeBSD HEAD to fix this, waiting for MFC period to pass.
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-07-22 10:16:03 UTC
A commit references this bug:

Author: bcr
Date: Sat Jul 22 10:15:11 UTC 2017
New revision: 321367
URL: https://svnweb.freebsd.org/changeset/base/321367

Log:
  MFC r321023:

  The ctladm man page incorrectly duplicated the text for the
  delete subcommand in the modify section. Rewrite the
  modify description text in two places to say modify/modified
  instead of remove/removed.

  PR:		220710
  Submitted by:	sseekamp@risei.net
  Reviewed by:	mav@
  Differential Revision:	https://reviews.freebsd.org/D11608

Changes:
_U  stable/11/
  stable/11/usr.sbin/ctladm/ctladm.8
Comment 5 Benedict Reuschling freebsd_committer freebsd_triage 2017-07-22 10:18:13 UTC
The MFC is done, so no need to keep this problem report open any longer.
Thank you for submitting the PR!