Bug 220715 - devel/libcutl: fails to build with boost 1.65
Summary: devel/libcutl: fails to build with boost 1.65
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Raphael Kubo da Costa
URL: https://github.com/boostorg/admin/iss...
Keywords: needs-patch
Depends on:
Blocks: 220714
  Show dependency treegraph
 
Reported: 2017-07-13 20:58 UTC by Jan Beich
Modified: 2017-07-15 13:09 UTC (History)
0 users

See Also:
rakuco: maintainer-feedback+


Attachments
Proposed patch (6.61 KB, patch)
2017-07-14 15:04 UTC, Raphael Kubo da Costa
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer 2017-07-13 20:58:07 UTC
checking if we should use external boost... yes
checking for boost base headers... yes
checking for boost regex library... no
checking for boost system library... yes
configure: error: boost regex is not found; consider using CPPFLAGS/LDFLAGS or --with-boost=DIR to specify its location
===>  Script "configure" failed unexpectedly.

configure:17644: c++ -c -O2 -pipe -fstack-protector -fno-strict-aliasing  -I/usr/local/include -I/usr/local conftest.cpp >&5
conftest.cpp:25:10: fatal error: 'boost/tr1/regex.hpp' file not found
#include <boost/tr1/regex.hpp>
         ^
[...]
| #include <boost/tr1/regex.hpp>
| 
| int
| main ()
| {
|   std::tr1::regex r ("te.t", std::tr1::regex_constants::ECMAScript);
|   return std::tr1::regex_match ("test", r) ? 0 : 1;
| }

http://sprunge.us/jTFN
Comment 1 Jan Beich freebsd_committer 2017-07-14 05:43:50 UTC
Sorry for See Also spam but the fixes for tr1/ headers disappearing are probably going to be same/similar.
Comment 2 Raphael Kubo da Costa freebsd_committer 2017-07-14 09:38:45 UTC
I'll take a look at this later today.
Comment 3 Raphael Kubo da Costa freebsd_committer 2017-07-14 15:04:49 UTC
Created attachment 184356 [details]
Proposed patch

Does this patch work for you? I tested it with the regular ports tree on HEAD-amd64 and 10.3-i386 by rm -fr'ing /usr/local/include/boost/tr1 and running make clean build.
Comment 4 Jan Beich freebsd_committer 2017-07-14 15:13:01 UTC
Comment on attachment 184356 [details]
Proposed patch

> Does this patch work for you?

Yes, it builds fine now: http://sprunge.us/QQEY
Comment 5 commit-hook freebsd_committer 2017-07-14 15:16:02 UTC
A commit references this bug:

Author: rakuco
Date: Fri Jul 14 15:15:31 UTC 2017
New revision: 445764
URL: https://svnweb.freebsd.org/changeset/ports/445764

Log:
  Stop using boost's tr1 regex implementation.

  tr1 is gone in the upcoming Boost 1.65. Adjust the code by switching to C++11's
  <regex> header instead. There is similar code in upstream's git repository, but
  it is mixed with a lot of other changes that make it infeasible to backport
  them directly.

  PR:		220715
  Reported by:	jbeich

Changes:
  head/devel/libcutl/Makefile
  head/devel/libcutl/files/
  head/devel/libcutl/files/patch-configure
  head/devel/libcutl/files/patch-cutl_re_re.cxx
Comment 6 Raphael Kubo da Costa freebsd_committer 2017-07-14 15:17:54 UTC
Thanks for testing!
Comment 7 Jan Beich freebsd_committer 2017-07-14 22:17:45 UTC
Don't you need to add USES=compiler:c++11-lib when using C++11 headers? powerpc*, sparc64 and mips* are still using old GCC/libstdc++ in base.
Comment 8 Raphael Kubo da Costa freebsd_committer 2017-07-15 13:07:30 UTC
Ugh, I always forget these tier-2 architectures with ancient compilers :(
Comment 9 commit-hook freebsd_committer 2017-07-15 13:09:31 UTC
A commit references this bug:

Author: rakuco
Date: Sat Jul 15 13:08:42 UTC 2017
New revision: 445873
URL: https://svnweb.freebsd.org/changeset/ports/445873

Log:
  Add USES=compiler:c++11-lib after r445764.

  While this doesn't change anything for tier-1 architectures, it makes the
  dependency on a modern compiler and standard library explicit for those
  platforms where GCC 4.2.1 is still the default.

  PR:		220715
  Reported by:	jbeich

Changes:
  head/devel/libcutl/Makefile