Created attachment 184360 [details]
Thank you Steffen. Please:
- Set the maintainer-approval flag on attachments (to +) to signify maintainer approval on patches for ports you are maintainer of.
- Confirm this change passes QA (portlint, poudriere in particular). For more infomation and instructions on testing, see: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/testing.html
thanks for your comment.
I added the flag and the QA is done on my systems since I maintain this port.
One question: Why was the MAINTAINER in the summary removed?
Created attachment 184369 [details]
same diff, added requested flag
Change passes QA.
Thank you Steffen
we normalize issue summaries because [tags] are a relic of gnats and beyond making summaries longer and more difficult to read, are an unstructured/imprecise method for determining the classification and/or state of an issue (and more importantly, the changes/patches/attachments within the issue)
maintainer-approval on the other hand is a flag associated with a patch (Attachment) rather than the overall issue itself and is used as the basis for the " Ports: Maintainer Approved " saved search that you should be able to see in the Bugzilla footer. This is the canonical list of "maintainer approved" issues that developers should and do use to determine what they can work on.
In the latest patch (attachment 184369 [details]), the version (PORTVERSION and distinfo checksums) go backward (1.7.4 -> 1.7.3) and an entire Makefile contents is added.
It appears there is a duplicate port directory within the parent:
Please re-check the diff creation procedure used, re-create the diff and update the patch
Created attachment 184398 [details]
corrected diff file
Fixed diff file.
this was a hard one... Fixed and uploaded.
A commit references this bug:
Date: Wed Jul 19 19:11:01 UTC 2017
New revision: 446226
Update to 1.7.4
Submitted by: Steffen <firstname.lastname@example.org> (maintainer)