Created attachment 184381 [details]
Patch to update x11/xfce4-terminal
Update to 0.8.6
This patch works for me.
When will be committed in the ports tree this and many other patches for xfce?
(In reply to Vladimir Omelchuk from comment #1)
When a committer will be interesting to Xfce.
As I'm not anymore ports committer I don't know when updates will be in ports tree. Perhaps tell to ports@ mailing list there are lots of updates for Xfce ports.
I noticed, if you have defined custom color for your cursor (CursorColor variable and its value are defined in .config/xfce4/terminal/terminalrc) you must add new variable ColorCursorUseDefault=FALSE (by default it's TRUE).
I think an update of files/pkg-message.in is needed or an new entry in UPDATING ir order to tell users their preferences are still present.
I think I found a bug.
After rename title tab, the cursor sometimes does not become active.
See example: http://files.dp.ua/file?source=17071921192340342266
I created PR for upstream: https://bugzilla.xfce.org/show_bug.cgi?id=13754
(In reply to Vladimir Omelchuk from comment #5)
Sorry Vladimir, I can't reproduce cursor behavior (also tested on Linux box).
Created attachment 185070 [details]
New patch to update x11/xfce4-terminal
Same patch as previously, with fix focus of title in popover (obtained from upstream repository).
Created attachment 186418 [details]
I revised your patch slightly.
I moved the USES line to make portlint happy and added the changes you suggest to pkg-message.
Does my wording in pkg-message look correct?
(In reply to Guido Falsi from comment #8)
Your patch looks fine.
In pkg-message, in fact if a user has defined color for his/her cursor and wants to keep its value. Value of ColorCursorUseDefault variable (it's new variable) must be equal to FALSE (by default it's TRUE). Other way, he/she goes to Preferences window.
(In reply to Olivier Duchateau from comment #9)
> (In reply to Guido Falsi from comment #8)
> Your patch looks fine.
> In pkg-message, in fact if a user has defined color for his/her cursor and
> wants to keep its value. Value of ColorCursorUseDefault variable (it's new
> variable) must be equal to FALSE (by default it's TRUE). Other way, he/she
> goes to Preferences window.
I see, I'll reword again to specify the user can add hte option by hand OR reconfigure via the UI (hope I got it right)
A commit references this bug:
Date: Mon Sep 18 15:15:53 UTC 2017
New revision: 450045
- Update x11/xfce4-terminal to 0.8.6
- Silence USES portlint warning
- Rework pkg-message, and add new informations
Submitted by: Olivier Duchateau <email@example.com>