Hi, There is another update coming to libhtp/suricata in a second and I noticed that there is a very old version here as well that no port uses. Should we remove it? Can provide a patch. Cheers, Franco
@Franco, I already have it in my todo list, thanks for creating an issue to track it
Want me to create the patch to free a bit of your time?
(In reply to Franco Fichtner from comment #2) I appreciate the thought, but it'll take me longer to fetch/patch from bugzilla or arc patch from Phabricator, that to write a MOVED line :) In future though (where changes are > trivial), Phabricator reviews are faster to fetch/apply patches from (arc patch DXXXX) -> profit)
Can try to write reviews instead. Should they go with bugzilla issues or can be opened independently?
(In reply to Franco Fichtner from comment #4) Yep, but reviews ("differential revisions") can replace patches (attachments) in the URL field. There's a couple of pros/cons here: - Con: Reviews don't have/track 'approval' of any kind (maintainer, etc), so I would only do this for things you are maintainer of, because 'approval' still needs to be tracked, and not having an attachment we can maintainer-approval + may give it less visibility. - Con: Reviews by default get a smaller audience than bugzilla issues (new ports issues are cc'd by default to mailing lists). - Pro: Reviews are good/better for more complex / less than trivial changes between a few people, say a mentor/mentee, you and i on something, a WIP port, if the 'final state' of a changeset is not entirely known (like a proposal/prototype), or is a lot of back/forth is needed/expected. - Pro: Reviews are easier to make 'commit reviews' (with proposed commit logs, proper formatting, etc) than bugs with patches, though I/we do encourage people to format their issues as close to commits as possible, see: https://wiki.freebsd.org/KubilayKocak/ThePerfectPortsIssue#General
A commit references this bug: Author: koobs Date: Sun Jul 16 10:43:06 UTC 2017 New revision: 445995 URL: https://svnweb.freebsd.org/changeset/ports/445995 Log: www/libhtp-suricata: Delete port (no longer required) security/suricata use to require and use a forked version of libhtp. This port was originally created for that reason, so as not to conflict with the concurrently developed and released libhtp. It is no longer required. * Remove entry from www/Makefile * Add MVOED entry PR: 220756 Changes: head/MOVED head/www/Makefile head/www/libhtp-suricata/
Thank you!