Bug 220763 - [NEW PORT] comms/hylafax+:
Summary: [NEW PORT] comms/hylafax+:
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kubilay Kocak
Keywords: feature, needs-qa
Depends on:
Reported: 2017-07-16 13:59 UTC by Martin Birgmeier
Modified: 2020-05-30 11:13 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (koobs)

Uuencoded tar file of comms/hylafax+ (13.82 KB, text/x-uuencode)
2017-07-16 13:59 UTC, Martin Birgmeier
no flags Details
hylafax+.shar, to be expanded in ports/comms (23.15 KB, text/plain)
2017-07-16 14:46 UTC, Martin Birgmeier
no flags Details
hylafax+.shar updated to 7.0.1, to be expanded in ports/comms (26.96 KB, text/plain)
2019-11-27 17:14 UTC, Martin Birgmeier
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Birgmeier 2017-07-16 13:59:43 UTC
Created attachment 184393 [details]
Uuencoded tar file of comms/hylafax+

Today I ran into the same problem described in bug #166071, so I ported HylaFAX+ from Sourceforge, which seems to work.

Since I am not too familiar with creating ports it would be good if someone with more knowledge could review this.

-- Martin
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2017-07-16 14:05:11 UTC
Thank you Martin,

If you could do the following it would be greatly appreciated:

- Submit the port as a shell archive, see [1]
- Run the port through QA (portlint, and poudriere in particular), see [2]

[1] (https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/book.html#porting-submitting
[2] https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/testing.html
Comment 2 Martin Birgmeier 2017-07-16 14:46:00 UTC
Created attachment 184396 [details]
hylafax+.shar, to be expanded in ports/comms
Comment 3 Martin Birgmeier 2017-07-16 14:46:35 UTC
I ran portlint -A; I corrected one warning but left those about 'make makepatch', because running 'make makepatch' interferes with the sed commands in the Makefile.

Shar attached.

I can't run poudriere, but tested the following:
- build on i386
- build on amd64
- operation on amd64

-- Martin
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2017-07-16 14:50:44 UTC
Thank you Martin
Comment 5 Martin Birgmeier 2017-07-16 16:15:14 UTC
Don't forget to add a CONFLICTS line to comms/hylafax/Makefile.


-- Martin
Comment 6 rnoll.bsd 2017-07-16 23:47:53 UTC
Thank you!

Comment 7 dgilbert 2019-11-26 22:41:33 UTC
Comment 8 Martin Birgmeier 2019-11-27 17:14:12 UTC
Created attachment 209489 [details]
hylafax+.shar updated to 7.0.1, to be expanded in ports/comms

Here an update to 7.0.1

-- Martin
Comment 9 daniel.engberg.lists 2020-03-18 07:48:23 UTC
Hi Martin,

I compiled your port (7.0.1) using Poudriere (12.1-RELEASE) and found a few issues.

MASTER_SITES is wrong, it should say SF/hylafax/hylafax which in turns requires a re-run of "make makesum"

While at it, please bump it to 7.0.2 as it seems to fix compatibiliy issues with (lib)tiff 4.1 which currently is in tree.

DISTFILE can also theoretically clash with comms/hylafax so please set DIST_SUBDIR to avoid that issue.
https://www.freebsd.org/doc/en/books/porters-handbook/makefile-distfiles.html --> 5.4.10

Please check if you can remove manual references of LOCALBASES with USES= localbase instead. https://www.freebsd.org/doc/en/books/porters-handbook/uses-localbase.html ?

USES= ssl is missing (it links to ssl)

stage-qa also warns about this:
Warning: /wrkdirs/usr/ports/comms/hylafax+/work/pkg-message not in UCL format, will be shown on initial install only.

# Defaults to "North American Letter".  Use "ISO A4" for A4. <-- It would be much more user friendly if it were a menu toggle (OPTIONS_SINGLE)

Also, when uploading a patch please select that it deprecates previous ones.

Great work!

Best regards,
Comment 10 Martin Birgmeier 2020-05-30 11:13:05 UTC
Not using this anymore.