Created attachment 184411 [details] removes libelf dependancy devel/gcc-arm-embedded has a LIB_DEPENDS of libelf.so:devel/libelf, but this dependancy will never be built on FreeBSD-10 and FreeBSD-11 which bundles this in the base system. Additionally, the dependancy results in a package validation failure during a synth build of the port.
Any response to this PR?
Comment on attachment 184411 [details] removes libelf dependancy Approved by: portmgr (maintainer timeout, 2 weeks) Pending committer review/QA
Hello Jonathan, it currently fails the QA stage with the following errors: ====> Running Q/A tests (stage-qa) Warning: 'gcc-arm-embedded-6-2017-q2-update/lib/libcc1.so.0' is not stripped consider trying INSTALL_TARGET=install-strip or using ${STRIP_CMD} Error: /usr/local/gcc-arm-embedded-6-2017-q2-update/bin/arm-none-eabi-gdb-py is linked to /usr/local/lib/libintl.so.8 from devel/gettext-runtime but it is not declared as a dependency Warning: you need USES+=gettext-runtime ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/man/man1/%%TARGET%%-gcov-dump.1.gz Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/man/man1/%%TARGET%%-gcov-tool.1.gz ===> Checking for items in pkg-plist which are not in STAGEDIR ===> Error: Plist issues found. *** Error code 1 Stop. make: stopped in /usr/ports/devel/gcc-arm-embedded Can you please have a look at it? It is very helpful to add DEVELOPER=yes to /etc/make.conf because than every qa is executed. Otherwise try make stage-qa and make check-plist to detect this kind of issues.
Created attachment 185176 [details] Updated patch for qa I've: - added the missing plist entries - updated the USES - corrected minor spelling mistake
A commit references this bug: Author: tz Date: Wed Aug 9 15:36:28 UTC 2017 New revision: 447629 URL: https://svnweb.freebsd.org/changeset/ports/447629 Log: devel/gcc-arm-embedded: Remove unnecessary LIB_DEPENDS on libelf Also: - added missing plist entries - add missing gettext-runtime to USES - corrected minor spelling mistake PR: 220782 Submitted by: Jonathan Chen <jonc@chen.org.nz> Approved by: portmgr (maintainer timeout, 2 weeks) MFH: 2017Q3 Changes: head/devel/gcc-arm-embedded/Makefile head/devel/gcc-arm-embedded/pkg-plist
A commit references this bug: Author: tz Date: Thu Aug 17 14:40:43 UTC 2017 New revision: 448107 URL: https://svnweb.freebsd.org/changeset/ports/448107 Log: MFH: r447629 devel/gcc-arm-embedded: Remove unnecessary LIB_DEPENDS on libelf Also: - added missing plist entries - add missing gettext-runtime to USES - corrected minor spelling mistake PR: 220782 Submitted by: Jonathan Chen <jonc@chen.org.nz> Approved by: portmgr (maintainer timeout, 2 weeks) Approved by: ports-secteam (feld) Changes: _U branches/2017Q3/ branches/2017Q3/devel/gcc-arm-embedded/Makefile branches/2017Q3/devel/gcc-arm-embedded/pkg-plist
Now also in quarterly, thanks! :)