Bug 220786 - audio/qjackctl: Update to 0.4.5
Summary: audio/qjackctl: Update to 0.4.5
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Richard Gallamore
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2017-07-17 05:04 UTC by Yuri Victorovich
Modified: 2017-07-20 20:17 UTC (History)
1 user (show)

See Also:


Attachments
patch (1.22 KB, patch)
2017-07-17 05:04 UTC, Yuri Victorovich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer 2017-07-17 05:04:38 UTC
Created attachment 184415 [details]
patch

Builds in poudriere.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2017-07-17 05:54:50 UTC
Thank you Yuri,

Reporters can help us save time and have issues seen quicker by setting maintainer-approval to + on attachments/patches they submit where the port has no maintainer.

Also for all future issues please provide details on QA, ie something like

* portlint: OK (looks fine.)
* testport: OK (poudriere: versions, archs, options)
Comment 2 Yuri Victorovich freebsd_committer 2017-07-17 06:03:41 UTC
I wrote "Builds in poudriere." -)
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2017-07-17 06:12:42 UTC
(In reply to Yuri Victorovich from comment #2)

I'm hinting that its highly beneficial to be more explicit and provide detail, which goes for everything related to issue/bug tracking. :) This is especially the case non-trivial changes.

tldr: "Leave no (even potential) questions unanswered" makes it much less likely an issue will be ignored and much more likely to promote action/progress.
Comment 4 Yuri Victorovich freebsd_committer 2017-07-17 06:21:56 UTC
(In reply to Kubilay Kocak from comment #3)

Ok!
Comment 5 commit-hook freebsd_committer 2017-07-20 20:16:26 UTC
A commit references this bug:

Author: ultima
Date: Thu Jul 20 20:16:12 UTC 2017
New revision: 446288
URL: https://svnweb.freebsd.org/changeset/ports/446288

Log:
  * Updated to 0.4.5
  *Sorted option section to follow 13.1.8[1]

  Changelog: https://qjackctl.sourceforge.io/qjackctl-downloads.html

  [1] https://www.freebsd.org/doc/en/books/porters-handbook/porting-samplem.html#porting-samplem-order

  PR:		220786
  Submitted by:	Yuri Victorovich <yuri@rawbw.com>
  Reviewed by:	lifanov (mentor)
  Approved by:	lifanov (mentor)
  Differential Revision:	https://reviews.freebsd.org/D11669

Changes:
  head/audio/qjackctl/Makefile
  head/audio/qjackctl/distinfo
  head/audio/qjackctl/pkg-plist
Comment 6 Richard Gallamore freebsd_committer 2017-07-20 20:17:23 UTC
Committed, thanks!