Bug 220842 - www/glpi: Add missing dependency: php56-curl php56-dom
Summary: www/glpi: Add missing dependency: php56-curl php56-dom
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Torsten Zuehlsdorff
URL:
Keywords: needs-patch
Depends on:
Blocks:
 
Reported: 2017-07-19 03:02 UTC by dasti
Modified: 2017-08-10 15:26 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (mathias)
koobs: merge-quarterly?

Attachments
glpi auto test (71.72 KB, image/png)
2017-07-19 03:02 UTC, dasti 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description dasti 2017-07-19 03:02:38 UTC 
Created attachment 184486 [details]
glpi auto test

hi !

freebsd 11
glpi 9.2

the compatibiliy test included in the glpi install process says that the php56-curl extension is missing

thanks
DS
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-08-07 14:27:44 UTC 
A commit references this bug:

Author: tz
Date: Mon Aug  7 14:27:08 UTC 2017
New revision: 447495
URL: https://svnweb.freebsd.org/changeset/ports/447495

Log:
  www/glpi: Add curl to PHP dependency list

  Without the extension the port is not functional

  PR:          220842
  Reported by: dasti <stievenard.david@gmail.com>
  MFH:         2017Q3

Changes:
  head/www/glpi/Makefile
Comment 2 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2017-08-07 14:30:46 UTC 
Because of the missing maintainer feedback i added the curl dependency by myself. 

I'm a little bit confused now: why did you added dom as missing? the screenshot does not show something like this?

Also i requested a merge into quarterly
Comment 3 dasti 2017-08-08 01:43:34 UTC 
Hi,

thanks for the help !

I just discovered that the php extension php56-dom is also missing
(necessary in the report section to draw graphs

(not sure I should modify this bug or create a new one...)
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-08-09 15:39:48 UTC 
A commit references this bug:

Author: tz
Date: Wed Aug  9 15:39:36 UTC 2017
New revision: 447630
URL: https://svnweb.freebsd.org/changeset/ports/447630

Log:
  MFH: r447495

  www/glpi: Add curl to PHP dependency list

  Without the extension the port is not functional

  PR:          220842
  Reported by: dasti <stievenard.david@gmail.com>

  Approved by: ports-secteam (zi)

Changes:
_U  branches/2017Q3/
  branches/2017Q3/www/glpi/Makefile
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-08-09 15:45:56 UTC 
A commit references this bug:

Author: tz
Date: Wed Aug  9 15:45:26 UTC 2017
New revision: 447631
URL: https://svnweb.freebsd.org/changeset/ports/447631

Log:
  www/glpi: Add dom to PHP dependency list

  Without the extension the port is not functional

  PR:          220842
  Reported by: dasti <stievenard.david@gmail.com>
  MFH:         2017Q3

Changes:
  head/www/glpi/Makefile
Comment 6 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2017-08-09 16:31:53 UTC 
(In reply to dasti from comment #3)

> (not sure I should modify this bug or create a new one...)

A new one would be correct, but lets don't get to bureaucracy. I fixed it now. Now the next issue should become a new PR.
Comment 7 commit-hook freebsd_committer freebsd_triage 2017-08-10 15:25:54 UTC 
A commit references this bug:

Author: tz
Date: Thu Aug 10 15:25:09 UTC 2017
New revision: 447685
URL: https://svnweb.freebsd.org/changeset/ports/447685

Log:
  MFH: r447631

  www/glpi: Add dom to PHP dependency list

  Without the extension the port is not functional

  PR:          220842
  Reported by: dasti <stievenard.david@gmail.com>

  Approved by: ports-secteam (zi)

Changes:
_U  branches/2017Q3/
  branches/2017Q3/www/glpi/Makefile
Comment 8 Torsten Zuehlsdorff freebsd_committer freebsd_triage 2017-08-10 15:26:14 UTC 
Also done and merged! :)