Bug 220846 - audio/teamspeak3-server: Fix startup on FreeBSD 11+ (Remove BROKEN)
Summary: audio/teamspeak3-server: Fix startup on FreeBSD 11+ (Remove BROKEN)
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Richard Gallamore
URL: https://reviews.freebsd.org/D11662
Keywords: easy, patch-ready
Depends on:
Blocks:
 
Reported: 2017-07-19 07:19 UTC by Denys Razumov
Modified: 2017-07-20 20:35 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (ultima)
koobs: merge-quarterly?


Attachments
Patch to run ts3 server on FreeBSD 11+ (266 bytes, patch)
2017-07-19 07:19 UTC, Denys Razumov
no flags Details | Diff
patch(git diff at /usr/ports) (969 bytes, patch)
2017-07-19 21:31 UTC, Denys Razumov
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Denys Razumov 2017-07-19 07:19:57 UTC
Created attachment 184490 [details]
Patch to run ts3 server on FreeBSD 11+

Now port audio/teamspeak3-server marked as broken
I make patch to fix this
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2017-07-19 07:53:22 UTC
If this is a sufficient patch to workaround the issue until bug 212493, please remove that bug as a dependency

Patch needs to be re-created as a diff against the port (as a files/patch-<file>, using `make makesum`) and have the BROKEN message removed
Comment 2 Denys Razumov 2017-07-19 09:32:51 UTC
This patch not for package src files, this patch for port files/teamspeak.in file
And patch from bug 212493 not needed
Comment 3 Richard Gallamore freebsd_committer 2017-07-19 18:41:33 UTC
I don't like wasting cycles on work arounds, but because of how simple this is, i'll accept it.
Comment 4 Denys Razumov 2017-07-19 21:31:02 UTC
Created attachment 184519 [details]
patch(git diff at /usr/ports)
Comment 5 Richard Gallamore freebsd_committer 2017-07-19 21:47:02 UTC
(In reply to Denys Razumov from comment #4)
Thanks, but I actually decided to take a different approach. This will only add the cd to the rc script on broken versions. I also changed the pkg-message a little to be more copy/paste friendly.

https://reviews.freebsd.org/D11662
Comment 6 commit-hook freebsd_committer 2017-07-20 20:33:45 UTC
A commit references this bug:

Author: ultima
Date: Thu Jul 20 20:33:12 UTC 2017
New revision: 446291
URL: https://svnweb.freebsd.org/changeset/ports/446291

Log:
  * Updated to 3.0.13.8
  * Fixed broken using cd in rc script as work around
  * Modified pkg-message to be more copy/paste friendly
  * Fixed whitespace to satisfy portlint

  Changelog: http://forum.teamspeak.com/threads/126318-TeamSpeak-3-Server-3-0-13-8-released

  PR:		220846
  Reported by:	Denys Razumov <zxzharmlesszxz@gmail.com>
  Reviewed by:	lifanov (mentor)
  Approved by:	lifanov (mentor)
  Differential Revision:	https://reviews.freebsd.org/D11662

Changes:
  head/audio/teamspeak3-server/Makefile
  head/audio/teamspeak3-server/distinfo
  head/audio/teamspeak3-server/files/pkg-message.in
  head/audio/teamspeak3-server/files/teamspeak.in
Comment 7 Richard Gallamore freebsd_committer 2017-07-20 20:35:43 UTC
Committed, thanks! There was also an update to 3.0.13.8 yesterday, I included this into the commit.